You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! incredible promises in your Readme.md (speed through Cython, easy API, etc.)
But I found the library a bit unfinished, so here are some (hopefully) constructive feedback:
Import error. After installing via git clone etc. in clean env, as required by readme.md, and just doing import gmatch4py as gm, I still encounter an import issue:
from .embedding.deepwalk import *
File "gmatch4py/embedding/deepwalk.pyx", line 29, in init gmatch4py.embedding.deepwalk
ModuleNotFoundError: No module named 'graph'
Autocompletion not working: maybe it's just in my IDE (Pycharm Pro), but I have no autocomplete of functions signatures, or no doctsrings displayed°. Do you have on your side?
2 bis) I know it takes time, but docs are not ultra clear for some functions (for example, how does .set_attr_graph_used works, how does it actually "use" attributes)
aka 2 bis²) : why does .set_attr_graph_used always took 2 arguments, can't we just use edge attr or node attr ? It seems not, but it's not clear to me why. TypeError: set_attr_graph_used() takes exactly 2 positional arguments (1 given)
° I think it might be because of compiled files .so. From my researchs, it seems docstrings are dropped by defaullt. But here, they give an option to keep docstrings: Cython.Compiler.Options.docstrings = True
Have a nice day, I hope my feedback will be useful. Again, thanks for open-sourcing your work!
Nicolas MICAUX
The text was updated successfully, but these errors were encountered:
Concerning the graph module import bug. Are you still in the Gmatch4py directory ? In this case, python will import unbuilt modules from the clone Gmatch4Py directory ... Maybe I should change the installation command by this one :
Regarding the auto-completion, I did not looked into it when I was developing the library. I'll try to add the Cython.Compiler.Options.docstrings = True in the setup.py.
As for attributes, I enabled the storage of nodes' attributes in my graph data structure for safety but none of the algorithms use it...
Are you still in the Gmatch4py directory ?
No, not when I run the import script.
I enabled the storage of nodes' attributes in my graph data structure for safety but none of the algorithms use it.
ok :) Maybe you should remove the In this latest version, we add the possibility to exploit graph attributes ! from readme.md, or explain that this are not used by builtin algorithms so far
Thx for taking time to answer me, have a nice day
Nicolas
Hi! incredible promises in your Readme.md (speed through Cython, easy API, etc.)
But I found the library a bit unfinished, so here are some (hopefully) constructive feedback:
git clone
etc. in clean env, as required by readme.md, and just doingimport gmatch4py as gm
, I still encounter an import issue:Autocompletion not working: maybe it's just in my IDE (Pycharm Pro), but I have no autocomplete of functions signatures, or no doctsrings displayed°. Do you have on your side?
2 bis) I know it takes time, but docs are not ultra clear for some functions (for example, how does
.set_attr_graph_used
works, how does it actually "use" attributes)aka 2 bis²) : why does
.set_attr_graph_used
always took 2 arguments, can't we just use edge attr or node attr ? It seems not, but it's not clear to me why.TypeError: set_attr_graph_used() takes exactly 2 positional arguments (1 given)
° I think it might be because of compiled files
.so
. From my researchs, it seems docstrings are dropped by defaullt. But here, they give an option to keep docstrings:Cython.Compiler.Options.docstrings = True
Have a nice day, I hope my feedback will be useful. Again, thanks for open-sourcing your work!
Nicolas MICAUX
The text was updated successfully, but these errors were encountered: