Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning a non-zero value from a callback results in an error #123

Merged
merged 1 commit into from Aug 18, 2014
Merged

Returning a non-zero value from a callback results in an error #123

merged 1 commit into from Aug 18, 2014

Conversation

jacquesg
Copy link
Owner

We should be passing GIT_EUSER to libgit2 and check for GIT_EUSER when the function returns.

@jacquesg
Stash.xs: Ignore GIT_EUSER, its not an error
2a13e98 
* Tag and Config may have been affected similarly. If the user
returns a non-zero value in the callback, pass GIT_EUSER to
libgit2 regardless of the actual value returned by the user.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling 2a13e98 on jacquesg/user-callback into e5bb418 on master.

@jacquesg jacquesg merged commit 2a13e98 into master Aug 18, 2014
@jacquesg jacquesg deleted the jacquesg/user-callback branch September 16, 2014 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacquesg @coveralls