Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSONQL (issue #31). #32

Merged
merged 3 commits into from Nov 13, 2018

Conversation

ShaheedHaque
Copy link

@ShaheedHaque ShaheedHaque commented May 23, 2018

I added support for the JSONQL 'driver' setting and the corresponding 'json_query' in the db_connections, a sample jsonql.jrxml file, as well as some supporting text in the README.rst file.

Please consider.

@coveralls
Copy link

coveralls commented May 23, 2018

Pull Request Test Coverage Report for Build 271

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 45.03%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyreportjasper/jasperpy.py 1 2 50.0%
Totals Coverage Status
Change from base Build 268: -0.4%
Covered Lines: 7166
Relevant Lines: 15914

💛 - Coveralls

@jadsonbr
Copy link
Collaborator

@ShaheedHaque Could you please write your routine test first?

@ShaheedHaque
Copy link
Author

@jadsonbr I have a test written but it won't pass without the updated jasperstarter, so I did not commit it yet. Upstream has merged their side of the change so I believe their CI builds now have the change, but they have obviously not released it.

I could push the failing new test? Can you advise how you wish me to proceed?

BTW, the subreports test fails for me (before and after this change).

@ShaheedHaque
Copy link
Author

The second commit is because I forgot to undo a test-related change in the jrxml. The dip in coverage (not sure why it was not reported before?) is due to the 1-line now not tested; that will be covered by the test I have written.

@ShaheedHaque
Copy link
Author

Upstream has said they plan to release with JasperReports 6.5.1 "in the next days". I suggest that if you were able to pull that in, I could then add the tests to this PR, and then you could consider the merge with (hopefully :-)) the coverage issue solved.

@jadsonbr
Copy link
Collaborator

As soon as I have available I update and I accept the PR

@ShaheedHaque
Copy link
Author

Great. If you could kindly let me know after you get the jasperstarter update (I will also try to keep watch), I will then add the tests to this PR. They should then pass (or I will fix them!), and then we'll be ready to merge.

@ShaheedHaque
Copy link
Author

I pushed the test, even though it fails without the support from upstream jasperstarter. I did this because the promised release from upstream has not happened, and I did not want to end up losing the code (e.g. by mistake). Clearly, this PR is now not mergable before the upstream support arrives.

@ShaheedHaque
Copy link
Author

@jadsonbr I've been working with upstream to get a new release out, and so there is now a 3.3 download with JSONQL support needed by this issue. It also has JasperReports 6.7. Pulling that should allow this PR to pass its tests, so please do consider integrating 3.3 and then merging this PR.

@jadsonbr
Copy link
Collaborator

I'll be watching this week

@jadsonbr jadsonbr merged commit 643d987 into acesseonline:master Nov 13, 2018
@jadsonbr
Copy link
Collaborator

Done

@ShaheedHaque
Copy link
Author

Many thanks. I look forward to a release in due course :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants