Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Spotify authentication popup blocked by some browsers #112

Closed
krzystke opened this issue May 16, 2017 · 14 comments
Closed

[Bug] Spotify authentication popup blocked by some browsers #112

krzystke opened this issue May 16, 2017 · 14 comments
Labels
bug P1 High priority (next release)

Comments

@krzystke
Copy link

I have problem with logging in to Spotify on Edge on Windows Mobile 10. Whenever I click LOG IN in Authentication section I just get "Popup blocked. Please allow popups and try again." and no authentication window. Can I bypass it somehow? Can you add option to open it in the same window or something? Edge doesn't seem to have enable popup option and managing Mopidy on mobile is crucial to me.
It is funny that it worked before I reinstalled everything (I needed to do that and change IP which forced me to log in again), and I have no idea how I made it.

@jaedb
Copy link
Owner

jaedb commented May 17, 2017

Sheesh, I'm a long time Windows user but Microsoft need to think harder about the quality of their new products. It will require significant work to use the existing window instead of opening in a new window as authorization events are sent between the two windows.

Is there any discussion about whether Microsoft will introduce this (standard) feature to their browser? In the meantime you can push your authorization credentials from another device. See the Share Authentication button.

@krzystke
Copy link
Author

krzystke commented May 17, 2017

Is there any discussion about whether Microsoft will introduce this (standard) feature to their browser?

I have no idea, but I think this problem is not new, but still not fixed. Anyway I logged somehow using mobile Edge before system update, so maybe current version of OS have extra problems with it and it will be fixed in the future. I need to do hard reset in my free time

In the meantime you can push your authorization credentials from another device. See the Share Authentication button.

Works great, thanks :)

@krzystke
Copy link
Author

Actually "Share Authentication" works but only for a while. Every time I do this after few hours I need to do this again, which is bad because the point of that is to have server, not to power on notebook every few hours to share access, but to listen to music headlessly. I dont know what breaks session but I am not doing anything extraordinary.

@krzystke krzystke reopened this May 20, 2017
@krzystke
Copy link
Author

Also I think this is not only Edge problem, but probably with Iris too. Logging in to Spotify on Mopify works great on the same browser, and Mopify is using the same system as Iris to log in (with external page Spotify authentication). Even popups works there.

@jaedb
Copy link
Owner

jaedb commented May 20, 2017

@krzystke Please open a new issue for the Share Authentication problems you're experiencing.

I don't have a WIndows phone to diagnose the underlying issue unfortunately.

The browser (Edge) makes it difficult to allow popups, but the fact that Mopify has been able to suggests popups can be permitted, somehow. Perhaps you had granted Mopify popup permission on another Windows device and this permission was synced to your mobile device?

@jaedb jaedb changed the title Can't login to Spotify on mobile (Edge/WM10) Spotify authentication popup blocked by Edge (Windows Mobile 10) May 20, 2017
@jaedb jaedb added the bug label May 20, 2017
@krzystke
Copy link
Author

Please open a new issue for the Share Authentication problems you're experiencing.

Sure, but first I need to find out what causes problem and is it only WM or Android too. I'll do research and come back with it later

Perhaps you had granted Mopify popup permission on another Windows device and this permission was synced to your mobile device?

It's not possible cause I've never used Mopify before (on PC or Mobile). I just installed almost all front end Mopidy addons to check if any of them works, and I can login to Spotify in Mopify on mobile without problems (it also uses pop up window to log in).

Also now I remember one more thing - few updates before (2.13.x I guess) I could login with mobile without any problems. It for sure wasn't sharing authentication, just regular login. Have you changed something with logging in module, or is it untouched for longer time?

@jaedb jaedb added the P1 High priority (next release) label May 24, 2017
@jaedb
Copy link
Owner

jaedb commented May 30, 2017

The SpotifyAuthenticationButton component hasn't been changed (besides minor style adjustments) in some time. Do other browsers work as expected on the same device?

@jaedb jaedb changed the title Spotify authentication popup blocked by Edge (Windows Mobile 10) [Bug] Spotify authentication popup blocked by some browsers Jun 8, 2017
@magsimal
Copy link

I am on iOS and have the same problem with Safari blocking the pop-up. Chrome on the same device works fine.
Curiously under the Mopify frontend the pop-up works in both browsers.

As a workaround one can disable blocking pop-ups in the settings BUT this won't help when using safari in fullscreen mode, i.e. if you set a bookmark to your homescreen to appear as an app.

@jaedb
Copy link
Owner

jaedb commented Jun 11, 2017

Mopify uses a different framework (Angular vs ReactJS) and has a different approach to the authentication process. Because the trigger is 'closer' to the click event then browsers don't seem to block the popup.

I'm exploring this a bit further to see if there are some simple workarounds.

@jaedb
Copy link
Owner

jaedb commented Jun 11, 2017

@magsimal and @krzystke can you please try pulling the master branch and test the fix? I've confirmed it works on Opera + Windows 10, however do not have the testing facility for Windows 10 mobile Edge.

@magsimal
Copy link

magsimal commented Jun 13, 2017

Hi @jaedb, it took me some time to get it running on my raspberry.
I can confirm that a pop-up now opens on iOS in both Safari and Chrome. It takes me to iris.barnsley.nz/auth.php with some parameters, however, the authentication does not go through - "the site can't be reached".

Anyway already many thanks for the great work!

@krzystke
Copy link
Author

@jaedb Unfortunately on Windows Mobile it's still borked, no popup is opening (just Iris error that pop up is blocked). Sharing authentication works but only for a limited time, when I try to enter website after a while I am logged out.
I think it's problem only with mobile Edge, it's really great that you were working hard on it by imo leave it, it's a lot of work for maybe 5 users (I don't know if Windows Mobile has more overall)

@jaedb
Copy link
Owner

jaedb commented Jun 13, 2017

@magsimal I've traced it back to some debug code and have updated it accordingly. Should be sorted now.

Seeing as we've remedied this as best we can, I'm closing the issue. If browsers continue to block the popup then there is really nothing more we can do. Spotify authentication must be opened in a popup.

@jaedb jaedb closed this as completed Jun 13, 2017
@magsimal
Copy link

Many thanks @jaedb you are a legend! Works now in Safari.

Only having an issue in safari full screen mode where after authentication the popup closes and you are not returned to the mopidy. As you do not have any tabs you are lost there. After reopening the website spotify is logged out again - but this seems more like a design flaw from apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 High priority (next release)
Projects
None yet
Development

No branches or pull requests

3 participants