Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tornado 5.1.1 #432

Closed
JerwuQu opened this issue Sep 7, 2019 · 4 comments
Closed

Support Tornado 5.1.1 #432

JerwuQu opened this issue Sep 7, 2019 · 4 comments
Labels

Comments

@JerwuQu
Copy link

JerwuQu commented Sep 7, 2019

The current version of Iris requires tornado<5.0, which is outdated for python2.

@JerwuQu JerwuQu added the bug label Sep 7, 2019
@kingosticks
Copy link
Contributor

kingosticks commented Sep 9, 2019

Arch seems to have stopped providing tornado 4.x. I think we've now fixed Mopidy's support for Tornado 5.x and we should be ready to remove our dependency restriction soon (mopidy/mopidy#1798). What is the cause of your requirement here for <5 ?

@JerwuQu
Copy link
Author

JerwuQu commented Sep 9, 2019

Exactly that - arch doesn't provide 4.x.

@kingosticks
Copy link
Contributor

Turns out this was already discussed at #275 (comment). From observation only it looks like it should be compatible but if we could find out more about the mentioned websocket issues that'd be useful in moving forward.

@JerwuQu
Copy link
Author

JerwuQu commented Sep 10, 2019

Ah, whoops! Don't know how I didn't see that one, though I guess bringing it to attention again doesn't hurt.

I'll close this in favor of that issue.

@JerwuQu JerwuQu closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants