Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect fresh state and auto-apply Snapcast defaults #776

Closed
tgurr opened this issue Oct 9, 2021 · 4 comments
Closed

Detect fresh state and auto-apply Snapcast defaults #776

tgurr opened this issue Oct 9, 2021 · 4 comments

Comments

@tgurr
Copy link

tgurr commented Oct 9, 2021

Describe the bug

First huge thanks for adding these options, since here it often happens users cleared their browser data, especially on mobile devices, and then found themselves not being able to use iris as snapcast was unconfigured again.

Now having configured the snapcast options (https://github.com/jaedb/Iris/wiki/Getting-started#configuration) and cleared browser history and/or opening iris in a privat browser tab, the initial configuration doesn't seem to get loaded from mopidy.conf.

To Reproduce
Steps to reproduce the behavior:

  1. configure mopidy for iris

/etc/mopidy/mopidy.conf

[iris]
enabled = true
country = DE
locale = de_DE
snapcast_enabled = true
snapcast_host = 192.168.0.10
snapcast_port = 1780
  1. stop/start or restart mopidy.service

  2. clear browser history and/or use privat tab to ensure nothing is cashed

  3. be presented with the initial "Welcome to Iris" screen and hit "Save"

  4. find clicking on the volume bar report "no outputs" and "Could not get Snapcast server" error message displayed

  5. review configuration screen and see values are not picked up from mopidy.conf
    iris_0

  6. click "Restore defaults" once
    iris_1

  7. See the correct values appearing and things starting to work correctly
    iris_2

Expected behavior
When viewing iris for the first time have it read out the configured default values and respect them without having to click "Restore defaults" first when the user didn't do any manual changes which would justify not loading/restoring the defaults configured in mopidy.conf.

Environment details:

  • OS: Linux
  • Browser: Latest Chrome & Firefox
  • Iris version: 3.59.1
@tgurr tgurr added the bug label Oct 9, 2021
@tgurr tgurr changed the title configured snapcast configuration not loaded on first view until manually clicking "restore defaults" once snapcast configuration not loaded on first view until manually clicking "restore defaults" once Oct 9, 2021
@jaedb jaedb changed the title snapcast configuration not loaded on first view until manually clicking "restore defaults" once Detect fresh state and auto-apply Snapcast defaults Oct 27, 2021
@jaedb jaedb added feature request and removed bug labels Oct 27, 2021
@jaedb
Copy link
Owner

jaedb commented Oct 27, 2021

Renaming to Feature request as the current functionality is not broken, rather it is a request to expand the feature. Personally I would like to change how this works, and instead have a server-side full set of defaults (ie not just for Snapcast).

@jaedb
Copy link
Owner

jaedb commented Mar 19, 2022

Thinking further about this, I think the best approach is to piggyback the existing "Share configuration" flow.

Instead of sending the selected config to another user, an option would exist where you could select "System defaults".

This feels like a practical option allowing the user to determine what is saved as the available defaults (including sensitive tokens, like Spotify Auth).

@jaedb
Copy link
Owner

jaedb commented Jun 19, 2022

Resolved indirectly by expanding Share configuration to push configuration to the server, so any other users can import it.

Also worth noting is that you can pre-seed your configuration via URL parameters.

@jaedb jaedb closed this as completed Jun 19, 2022
@tgurr
Copy link
Author

tgurr commented Jun 19, 2022

Thanks, but that's still very cumbersome as the configuration pushed/saved to the server is not auto-loaded when a new user openes the iris interface or e.g. after deleting browser cache. So the user still has to go manually to setting and import the configuration from the server, this is just something a "regular consumer" isn't capable of, they need to be able to click the url and find everything working ootb. I'm with mczerski here #848 (comment) a good old setting in mopidy.conf respected by iris would be the most convenient solution as everything else is configured there as well. But I could probably also live with the share configuration stuff by iris itself if it would at least import the server configuration (if there is any saved) automatically for new users.

Edit: Thanks for the pre-seed configuration via URL parameters, I'll go for that workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants