Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

update hunter version to use a newer opentracing-cpp? #118

Closed
ppggff opened this issue Jul 30, 2018 · 5 comments
Closed

update hunter version to use a newer opentracing-cpp? #118

ppggff opened this issue Jul 30, 2018 · 5 comments

Comments

@ppggff
Copy link

ppggff commented Jul 30, 2018

The build-in version hunter will build with opentracing-cpp 1.4.0, and the "plugin so" will return error with other version.

@isaachier
Copy link
Contributor

Good catch. Will update now. Thanks.

@isaachier
Copy link
Contributor

@rnburn, while doing this, discovered that Jaeger does not implement new OpenTracing dynamic loading function. Where do I use OPENTRACING_DECLARE_IMPL_FACTORY? In the implementation file (DynamicLoad.cpp) or in the tracer factory header (TracerFactory.h)?

@rnburn
Copy link
Contributor

rnburn commented Jul 30, 2018

Yes, in the implementation file. It was added to support building on windows.

@mdouaihy updated it as part of his PR. You can see https://github.com/mdouaihy/jaeger-client-cpp/blob/9091fc42ed356cd51e640c039623279e0a4de761/src/jaegertracing/DynamicLoad.cpp

@ppggff
Copy link
Author

ppggff commented Jul 31, 2018

It would be better to add the version number of corresponding opentracing-cpp with the released binary plugin library file.

@isaachier
Copy link
Contributor

Fixed in #120.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants