Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

sampler logger is NullLogger #608

Open
tttoad opened this issue Apr 20, 2022 · 0 comments
Open

sampler logger is NullLogger #608

tttoad opened this issue Apr 20, 2022 · 0 comments
Labels

Comments

@tttoad
Copy link

tttoad commented Apr 20, 2022

Sampler initialization without logger injection.

func (sc *SamplerConfig) NewSampler(
	serviceName string,
	metrics *jaeger.Metrics,
) 

should be change to

func (sc *SamplerConfig) NewSampler(
	serviceName string,
	metrics *jaeger.Metrics,
	logger jaeger.Logger
) 

like

func (rc *ReporterConfig) NewReporter(
	serviceName string,
	metrics *jaeger.Metrics,
	logger jaeger.Logger,
) (jaeger.Reporter, error) {
@tttoad tttoad added the bug label Apr 20, 2022
@tttoad tttoad mentioned this issue Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant