Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the operator can inject sidecars from instances in other namespaces #505

Closed
jpkrohling opened this issue Jul 5, 2019 · 9 comments

Comments

@jpkrohling
Copy link
Contributor

See #60 (comment) for context.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Jul 5, 2019

cc @christianhuening and @kevinearls

@objectiser
Copy link
Contributor

objectiser commented Jul 5, 2019

I deployed the jaeger-operator based on an image of the latest master - the operator in "observability" namespace, the deploy/example/simplest.yaml CR in a monitoring namespace and finally an example in the example namespace - the deployment including the sidecar.jaegertracing.io/inject: "true" annotation.

The agent was injected as expected.

@christianhuening
Copy link

@objectiser oh cool! How did you deploy the jaeger-operator? Did you use the helm chart?
If not, what did you set the WATCH_NAMESPACE variable to?

@objectiser
Copy link
Contributor

@christianhuening I used the instructions in this section of the readme: https://github.com/jaegertracing/jaeger-operator#kubernetes, but updated the operator.yaml to use an image built from the current master. So it is using WATCH_NAMESPACE="".

I'll be doing a patch release shortly, so should be available soon.

@christianhuening
Copy link

christianhuening commented Jul 5, 2019

@objectiser you released 1.13.1, but I cannot find/get an image with that tag. Is that pending in CI?

@christianhuening
Copy link

Ok thanks, it's there now.
Now finally the RBAC settings in the helm chart only use Roles and RoleBinding, instead of a ClusterRole and ClusterRole binding. Will open a PR then.

@jpkrohling
Copy link
Contributor Author

Ok thanks, it's there now.

I had to push it manually, as we had the same problem as with the latest releases (only one tag gets pushed).

@christianhuening
Copy link

christianhuening commented Jul 5, 2019

so it indeed is working, but for the helm chart version the RBAC files require updates to use ClusterRole and ClusterRoleBinding instead of namespace local versions. I tested that and then it is working. The kubernetes deployment files from the main jaeger repo are working out of the box across namespaces. I think we can close this issue.

@jpkrohling
Copy link
Contributor Author

Thanks for verifying, @christianhuening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants