Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag search does not support spaces in value #210

Closed
nziebart opened this issue May 7, 2018 · 4 comments
Closed

Tag search does not support spaces in value #210

nziebart opened this issue May 7, 2018 · 4 comments
Labels

Comments

@nziebart
Copy link

nziebart commented May 7, 2018

Description
If a tag value includes spaces, it cannot be searched for via the tag search bar. This happens, for example, with sql queries: SELECT * FROM foo.
EDIT: see minimal example below

Steps to reproduce the issue:

  1. Insert a span with a tag that has a space in the value.
  2. Attempt to search for the tag via the search box

Describe the results you received:
The trace is not found

Describe the results you expected:
The trace should be found

Additional information you deem important (e.g. issue happens only occasionally):
I have tried various things such as escaping, mucking with the actual URL query paramts, etc. I was not able to get this to work

Additional environment details (Browser, etc.):

@nziebart
Copy link
Author

nziebart commented May 8, 2018

As a minimal example, searching for the tag value foo bar does not work. I have tried with both elasticsearch backend and the in-memory backend (from the all in one docker image).

Screenshot of tag value:
screen shot 2018-05-08 at 11 57 22 am
It cannot be found via search:
screen shot 2018-05-08 at 11 57 37 am

@nziebart nziebart changed the title Tag search does not support quotes in value Tag search does not support spaces in value May 8, 2018
@tiffon
Copy link
Member

tiffon commented Jun 17, 2018

@nziebart Thanks for filing this ticket!

So far I'm unable to reproduce the issue. I tried our cassandra backed deployment and the all-in-one Docker image (in-memory backed) with the HotROD demo. So far seems like it's working.

In memory + HotROD demo search results

screen shot 2018-06-16 at 10 56 23 pm

This might seem like a silly question, but was the span with the tag test="foo bar" from the test service? Searching the root service for tags on a child span from some other service has tripped me up before.

Can you share any of the code you used for the minimal example?

@tiffon tiffon added the bug label Jun 17, 2018
@tiffon
Copy link
Member

tiffon commented Jul 11, 2018

@nziebart – Just checking in... Are you still seeing this issue?

@tiffon
Copy link
Member

tiffon commented Jul 25, 2018

Closing due to inability to reproduce and lack of response from OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants