Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger should have a contextpath and allow to customize #258

Closed
clyang82 opened this issue Sep 29, 2018 · 3 comments
Closed

Jaeger should have a contextpath and allow to customize #258

clyang82 opened this issue Sep 29, 2018 · 3 comments

Comments

@clyang82
Copy link
Contributor

clyang82 commented Sep 29, 2018

I have a case to integrate some ui together and expose them by using the same ingress controller. here is an example ingress file:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: jaeger-search-ingress
  namespace: istio-system
  labels:
    app: jaeger
  annotations:
      kubernetes.io/ingress.class: xxx
spec:
  rules:
    - http:
        paths:
          - path: /search
            backend:
              serviceName: jaeger-query
              servicePort: 16686
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: jaeger-static-ingress
  namespace: istio-system
  labels:
    app: jaeger
  annotations:
      kubernetes.io/ingress.class: xxx
spec:
  rules:
    - http:
        paths:
          - path: /static
            backend:
              serviceName: jaeger-query
              servicePort: 16686

from the above example, the path '/static' and '/search' are very common path. if the 2 applications have the same path, we cannot expose them by the same ingress controller. kiali is using 'static' while jaeger is using 'static' as well.

If the application have the contextpath, then we can use the following way to achieve this goal. Take 'jaeger' as an example to explain:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: jaeger
  namespace: istio-system
  labels:
    app: jaeger
  annotations:
      kubernetes.io/ingress.class: xxx
      icp.management.ibm.com/rewrite-target: /jaeger
spec:
  rules:
    - http:
        paths:
          - path: /jaeger
            backend:
              serviceName: jaeger-query
              servicePort: 16686

so we should have a contextpath for the application. for jaeger application, can we consider to have a contextpath? Thanks.

@clyang82 clyang82 changed the title Jaeger should have a contextpath Jaeger should have a contextpath and allow to customize Sep 29, 2018
@yurishkuro
Copy link
Member

you can configure jaeger-query to run at a custom prefix, like /jaeger

$ go run ./cmd/query/main.go help | grep base-path
      --query.base-path string                          The base path for all HTTP routes, e.g. /jaeger; useful when running behind a reverse proxy (default "/")

@yurishkuro
Copy link
Member

@clyang82
Copy link
Contributor Author

I have tested with v1.7 and it is working. Thanks @yurishkuro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants