Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to copy & paste span ID #360

Closed
yurishkuro opened this issue Mar 26, 2019 · 6 comments
Closed

Unable to copy & paste span ID #360

yurishkuro opened this issue Mar 26, 2019 · 6 comments
Assignees

Comments

@yurishkuro
Copy link
Member

Requirement - what kind of business use case are you trying to solve?

I can't to highlight span IU to copy & paste it elsewhere.

Problem - what in Jaeger blocks you from solving the requirement?

The popup shows saying "click to add to filter", the span ID cannot be highlighted either by double-clicking or by dragging the mouse.

image

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add a magnifying glass for "click to add to filter" next to the span ID, leave span ID as plain text.

@yurishkuro yurishkuro changed the title Poor usability with "span id filtering" Unable to copy & paste span ID Mar 26, 2019
@everett980
Copy link
Collaborator

What are your thoughts on making the tooltip the clickable element instead?
Or instead of an add to filter icon, add a copy icon next to the ID which is a pattern present on KV tables and graph nodes?

Temporary work around: Right click the button (spanID) and select "copy"

@yurishkuro
Copy link
Member Author

Copy button might work. What is the use case for adding span ID to the filter anyway? I am already looking at it.

@everett980
Copy link
Collaborator

The filter is shareable, so a user can add the ID then copy the url to send a link to a specific span within the trace. Or multiple spans if they select multiple IDs.

@tiffon
Copy link
Member

tiffon commented Mar 27, 2019

@yurishkuro, @everett980

I think it makes sense to have an icon for both filtering and copying. Currently, the filter functionality has a low level of discoverability.

OTOH, it's reasonable for the filter icon to actually be a share icon, since that's when adding it to the filter really makes sense.

Yuri, not sure if you're aware, but whatever is in the find input is added to the URL. And, if a URL with a uiFind value is viewed, then the parent spans that aren't ancestors of matching spans are collapsed and the spans that match have their details expanded. For instance, here is an entry with three matching spans:

image

I think it makes to add a button on the Find input, near the up and down arrows, that triggers the collapsing of parents that aren't ancestors of matching nodes. Created #361 to capture this.

@everett980
Copy link
Collaborator

I think the simplest way to address this copy id regression and #361 is to add a small "add to filter" icon next to spanID that says "Click to add to filter for deep linking". Then next to the nav buttons, add the expand/collapse button mentioned in #361 and add a new button with a share icon. That icon would copy the current url to the user's clipboard with a tooltip that says "Copy deep link to this filter" or something similar.

It doesn't help discoverability for uiFind on traceDiff but would address these two issues and help with discoverability on the single trace view.

@tiffon
Copy link
Member

tiffon commented May 13, 2019

Fixed in #367.

@tiffon tiffon closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants