-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to copy & paste span ID #360
Comments
What are your thoughts on making the tooltip the clickable element instead? Temporary work around: Right click the button (spanID) and select "copy" |
Copy button might work. What is the use case for adding span ID to the filter anyway? I am already looking at it. |
The filter is shareable, so a user can add the ID then copy the url to send a link to a specific span within the trace. Or multiple spans if they select multiple IDs. |
I think it makes sense to have an icon for both filtering and copying. Currently, the filter functionality has a low level of discoverability. OTOH, it's reasonable for the filter icon to actually be a share icon, since that's when adding it to the filter really makes sense. Yuri, not sure if you're aware, but whatever is in the find input is added to the URL. And, if a URL with a I think it makes to add a button on the Find input, near the up and down arrows, that triggers the collapsing of parents that aren't ancestors of matching nodes. Created #361 to capture this. |
I think the simplest way to address this copy id regression and #361 is to add a small "add to filter" icon next to spanID that says "Click to add to filter for deep linking". Then next to the nav buttons, add the expand/collapse button mentioned in #361 and add a new button with a share icon. That icon would copy the current url to the user's clipboard with a tooltip that says "Copy deep link to this filter" or something similar. It doesn't help discoverability for uiFind on traceDiff but would address these two issues and help with discoverability on the single trace view. |
Fixed in #367. |
Requirement - what kind of business use case are you trying to solve?
I can't to highlight span IU to copy & paste it elsewhere.
Problem - what in Jaeger blocks you from solving the requirement?
The popup shows saying "click to add to filter", the span ID cannot be highlighted either by double-clicking or by dragging the mouse.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Add a magnifying glass for "click to add to filter" next to the span ID, leave span ID as plain text.
The text was updated successfully, but these errors were encountered: