Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results DDG looks incorrect for hotrod data #485

Closed
yurishkuro opened this issue Nov 19, 2019 · 7 comments · Fixed by #504
Closed

Search results DDG looks incorrect for hotrod data #485

yurishkuro opened this issue Nov 19, 2019 · 7 comments · Fixed by #504
Labels

Comments

@yurishkuro
Copy link
Member

@everett980 a bunch of edges in this graph are incorrect

Screen Shot 2019-11-18 at 5 40 47 PM

@pavolloffay pavolloffay added the bug label Dec 4, 2019
@everett980
Copy link
Collaborator

@yurishkuro If you hit the "view traces" button on the node interactions popup do the traces show the same issue?
Thanks to recent changes there should only be one focal node if you revisit this now, but the edges themselves I'm not sure about. It's possibly they are reversed.

@yurishkuro
Copy link
Member Author

I am seeing this with the latest release 1.15.1. Steps to reproduce:

  1. Edit examples/hotrod/docker-compose.yml by replacing all-in-one:latest with all-in-one:1.15.1:
--- a/examples/hotrod/docker-compose.yml
+++ b/examples/hotrod/docker-compose.yml
@@ -1,7 +1,7 @@
 version: '3.7'
 services:
   jaeger:
-    image: jaegertracing/all-in-one:latest
+    image: jaegertracing/all-in-one:1.15.1
     ports:
       - "6831:6831/udp"
       - "16686:16686"
  1. docker-compse up
  2. open http://0.0.0.0:8080/, hit buttons 3 times
  3. open http://localhost:16686/, select dispatch service, search for traces, and hit DDG button.

@everett980
Copy link
Collaborator

I still haven't had a chance to dig into this further, but one issue could be that we aren't filtering paths to just span.kind === 'server' like we do in the flink job.

@yurishkuro
Copy link
Member Author

I don't fully agree with how flink job does it anyway, but this doesn't sound like the issue at hand, because the graphs are just wrong, arrows pointing in the wrong directions, etc.

@cykl
Copy link

cykl commented Dec 18, 2019

I'm still experiencing the same issue with 1.6.0. Most our DDGs look bogus with impossible arrows, mixed upstream / downstream dependencies etc. I might be able to share trace JSON if that might help.

@cykl
Copy link

cykl commented Feb 17, 2020

Is a patch release planned?

@yurishkuro
Copy link
Member Author

1.17 is coming up soon jaegertracing/jaeger#2057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants