Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Navbar overlapping and css overflow in deep dependency section #731

Closed
meenal06 opened this issue Apr 8, 2021 · 4 comments · Fixed by #782
Closed

[bug] Navbar overlapping and css overflow in deep dependency section #731

meenal06 opened this issue Apr 8, 2021 · 4 comments · Fixed by #782

Comments

@meenal06
Copy link
Contributor

meenal06 commented Apr 8, 2021

Current Behaviour

The deep dependency graph section overlaps and cutout the navigation bar when scrolled

Expected Behaviour

Remove the css overflow and intersection of nav-bar

Screenshot

Screenshot 2021-04-09 at 2 03 33 AM

@meenal06
Copy link
Contributor Author

meenal06 commented Apr 8, 2021

Hi @yurishkuro can you please assign me this issue?

@ampaire
Copy link

ampaire commented May 3, 2021

Hello, @yurishkuro has this issue been worked on?

@meenal06
Copy link
Contributor Author

meenal06 commented May 3, 2021 via email

@stardotcode
Copy link
Contributor

I was able to repro this issue.

  • the overlap happens when the window height is less than 680px
  • the fixed page header element (Page--topNav) has z-index: 3 (Page.css:Line22), however the Deep Dependencies header element (DdgHeader) has z-index: 10 (index.css:Line25).

I'm not very familiar with the codebase yet, so don't know why the z-index is set to 10.

A quick fix would be to bump the fixed page header element's z-index to 11

stardotcode pushed a commit to stardotcode/jaeger-ui that referenced this issue Jul 7, 2021
Bump up the z-index of page header element so that the deep
dependency header doesn't overlap when scrolling down.

Resolves jaegertracing#731

Signed-off-by: Neil Sharma <stardotcode@engineer.com>
stardotcode pushed a commit to stardotcode/jaeger-ui that referenced this issue Jul 7, 2021
Bump up the z-index of page header element so that the deep
dependency header doesn't overlap when scrolling down.

Resolves jaegertracing#731

Signed-off-by: Neil Sharma <stardotcode@engineer.com>
albertteoh pushed a commit that referenced this issue Jul 8, 2021
Bump up the z-index of page header element so that the deep
dependency header doesn't overlap when scrolling down.

Resolves #731

Signed-off-by: Neil Sharma <stardotcode@engineer.com>
leroy-chen pushed a commit to leroy-chen/jaeger-ui that referenced this issue Jul 16, 2021
jaegertracing#782)

Bump up the z-index of page header element so that the deep
dependency header doesn't overlap when scrolling down.

Resolves jaegertracing#731

Signed-off-by: Neil Sharma <stardotcode@engineer.com>
Signed-off-by: leroy-chen <leroy.chen.179@gmail.com>
leroy-chen pushed a commit to leroy-chen/jaeger-ui that referenced this issue Jul 16, 2021
jaegertracing#782)

Bump up the z-index of page header element so that the deep
dependency header doesn't overlap when scrolling down.

Resolves jaegertracing#731

Signed-off-by: Neil Sharma <stardotcode@engineer.com>
Signed-off-by: leroy-chen <leroy.chen.179@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants