Skip to content

Filtering duplicate spans #4894

Answered by yurishkuro
ricardokirkner asked this question in Q&A
Discussion options

You must be logged in to vote

Our other storage backends use primary keys based on span ID, so they should naturally dedupe identical spans (although to be confirmed if that's the case for Elasticsearch). The in-memory storage does not implement such de-duplication.

Overall, it seems like a reasonable function to have to dedupe identical spans on read. A bit of a caveat there is that Zipkin's legacy model assumes the same span ID between client and server, so we already had some logic to handle that.

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@ricardokirkner
Comment options

Answer selected by ricardokirkner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants