Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger log output to file #1775

Closed
chopper-poet opened this issue Sep 6, 2019 · 5 comments
Closed

Jaeger log output to file #1775

chopper-poet opened this issue Sep 6, 2019 · 5 comments
Labels

Comments

@chopper-poet
Copy link

if there a way to output log to a logfile and carve up by date,like this '2019-09-06.log'

@guanw
Copy link
Contributor

guanw commented Sep 6, 2019

@panjunDev Does this help?

@chopper-poet
Copy link
Author

@panjunDev Does this help?

yes.

@pavolloffay
Copy link
Member

I was about to close this, however zap supports logging to a file uber-go/zap#294. We could have a switch with paths to log files.

@pavolloffay pavolloffay changed the title jaeger log output to logfile Jeger log output to file Sep 9, 2019
@yurishkuro
Copy link
Member

I would not recommend it. There are some scenarios where zap is not yet initialized and we write to stdout/err. And in general, knowing what to do with logs is the business of the orchestration system, not the application. If we start writing to files, we need to rotate them, that's additional configuration, etc.

@pavolloffay
Copy link
Member

Let's close this then. We don't want to pull in more logic for log management.

Users can redirect stdout/stderr to a file and rotate it by an external utility like logrotate - https://linux.die.net/man/8/logrotate

@yurishkuro yurishkuro changed the title Jeger log output to file Jaeger log output to file Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants