Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: cmd/query/app.NewGRPCHandler removed without alternatives #4082

Closed
vprithvi opened this issue Dec 2, 2022 · 0 comments · Fixed by #4083
Closed

[Bug]: cmd/query/app.NewGRPCHandler removed without alternatives #4082

vprithvi opened this issue Dec 2, 2022 · 0 comments · Fixed by #4083
Labels
bug

Comments

@vprithvi
Copy link
Contributor

vprithvi commented Dec 2, 2022

Requirement

Ability to get a GRPCHandler which can be used with a custom server

Problem

In #3091, it looks like app.NewGRPCHandler was removed accidentally - as this is a exported function, it breaks semver.

Proposal

Add app.NewGRPCHandler back.

Open questions

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore NewGRPCHandler method vprithvi/jaeger
1 participant
@vprithvi