Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Jaeger to github.com/jaegertracing #409

Closed
9 tasks done
yurishkuro opened this issue Sep 20, 2017 · 7 comments
Closed
9 tasks done

Migrate Jaeger to github.com/jaegertracing #409

yurishkuro opened this issue Sep 20, 2017 · 7 comments

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Sep 20, 2017

The process for each repo typically involves:

  • Doing the repo move
  • Re-registering the repo with Travis
  • Re-registering the repo with Coveralls/CodeCov
  • Re-encrypting credentials
  • Updating the links to badges in the README
  • Adding DCO file
  • Adding sign-off checker bot
  • Updating CONTRIBUTING instructions to require sign-off
  • If not done yet, updating to Apache license
    • Replacing LICENSE file
    • Updating CONTRIBUTING instructions and references to license in the README
    • Updating the check-license script
@caniszczyk
Copy link
Contributor

@yurishkuro I installed prbot (https://github.com/organizations/jaegertracing/settings/installations/54533) to help us enforce DCO checking on github.com/jaegartracing which I will enforce once the repos are moved over.

@yurishkuro
Copy link
Member Author

@caniszczyk https://github.com/uber/jaeger was moved

@dstroot
Copy link
Contributor

dstroot commented Sep 25, 2017

Note the example (HotROD) still has a lot of code referencing https://github.com/uber/jaeger.

@yurishkuro
Copy link
Member Author

@dstroot that's not going to change (anytime soon), because changing import paths is unbelievably painful in Go (e.g. sirupsen/logrus#570)

@dstroot
Copy link
Contributor

dstroot commented Sep 25, 2017

Thanks Yuri - I have read the blog post and watched the video (great work BTW) from seeing the HN post yesterday. I was playing with it last night and got it running, and I am running Jaeger in a container as instructed, but the really strange thing is zero data is being picked up in Jaeger (it remains empty). Any suggestions where to look?

❯ go run ./main.go all
2017-09-25T08:25:03.583-0700	INFO	cmd/all.go:25	Starting all services
2017-09-25T08:25:03.585-0700	INFO	log/logger.go:37	Starting	{"service": "route", "address": "http://127.0.0.1:8083"}
2017-09-25T08:25:03.585-0700	INFO	log/logger.go:37	Starting	{"service": "frontend", "address": "http://127.0.0.1:8080"}
2017-09-25T08:25:03.586-0700	INFO	log/logger.go:37	Starting	{"service": "customer", "address": "http://127.0.0.1:8081"}
2017-09-25T08:25:03.586-0700	INFO	log/logger.go:37	TChannel listening	{"service": "driver", "hostPort": "127.0.0.1:8082"}
2017-09-25T08:25:12.081-0700	INFO	log/spanlogger.go:34	HTTP	{"service": "frontend", "method": "GET", "url": "/"}
2017-09-25T08:25:12.311-0700	INFO	log/spanlogger.go:34	HTTP	{"service": "frontend", "method": "GET", "url": "/favicon.ico"}
2017-09-25T08:25:13.530-0700	INFO	log/spanlogger.go:34	HTTP request received	{"service": "frontend", "method": "GET", "url": "/dispatch?customer=392&nonse=0.20580429722881766"}
2017-09-25T08:25:13.530-0700	INFO	log/spanlogger.go:34	Getting customer	{"service": "frontend", "component": "customer_client", "customer_id": "392"}
2017-09-25T08:25:13.530-0700	INFO	log/spanlogger.go:34	HTTP request received	{"service": "customer", "method": "GET", "url": "/customer?customer=392"}
2017-09-25T08:25:13.530-0700	INFO	log/spanlogger.go:34	Loading customer	{"service": "customer", "component": "mysql", "customer_id": "392"}
2017-09-25T08:25:13.884-0700	INFO	log/spanlogger.go:34	Found customer	{"service": "frontend", "customer": {"ID":"392","Name":"Trom Chocolatier","Location":"577,322"}}
2017-09-25T08:25:13.884-0700	INFO	log/spanlogger.go:34	Finding nearest drivers	{"service": "frontend", "component": "driver_client", "location": "577,322"}
2017-09-25T08:25:13.885-0700	INFO	log/spanlogger.go:34	Searching for nearby drivers	{"service": "driver", "location": "577,322"}
2017-09-25T08:25:13.945-0700	ERROR	log/spanlogger.go:39	redis timeout	{"service": "driver", "driver_id": "T731814C", "error": "redis timeout"}
github.com/jaegertracing/jaeger/examples/hotrod/vendor/go.uber.org/zap.Stack
	/Users/Dan/Go/src/github.com/jaegertracing/jaeger/examples/hotrod/vendor/go.uber.org/zap/field.go:209
github.com/jaegertracing/jaeger/examples/hotrod/vendor/go.uber.org/zap.(*Logger).check
	/Users/Dan/Go/src/github.com/jaegertracing/jaeger/examples/hotrod/vendor/go.uber.org/zap/logger.go:273
...

@yurishkuro
Copy link
Member Author

@dstroot please use https://gitter.im/jaegertracing/Lobby for questions.

@yurishkuro
Copy link
Member Author

all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants