Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]: Deprecate grpc-plugin (sidecar) support #4409

Closed
yurishkuro opened this issue Apr 25, 2023 · 1 comment
Closed

[Proposal]: Deprecate grpc-plugin (sidecar) support #4409

yurishkuro opened this issue Apr 25, 2023 · 1 comment

Comments

@yurishkuro
Copy link
Member

Requirement

As maintainers we want to minimize the amount of code and niche use cases we must support.

Problem

Storage plugins were originally implemented via hashicorp/grpc-plugin library, which requires running a sidecar process implementing the plugin. Since this process communicates with the main binary via gRPC API, we later realized that we could also support a Remote Storage API implemented by independent gRPC servers, which is generally a more flexible model than running a sidecar, while the sidecar mode is still possible via special deployment, e.g. in k8s. So now we support two variants of storage plugins, which is both confusing to the users and doubles the amount of code to support.

Proposal

Deprecate the use of sidecar plugin model, and only support remote storage API via gRPC.

cc @jaegertracing/jaeger-maintainers

Open questions

No response

@yurishkuro yurishkuro changed the title [Propolal]: Deprecate grpc-plugin support [Proposal]: Deprecate grpc-plugin support Apr 25, 2023
@yurishkuro yurishkuro changed the title [Proposal]: Deprecate grpc-plugin support [Proposal]: Deprecate grpc-plugin (sidecar) support Apr 25, 2023
@yurishkuro
Copy link
Member Author

duplicate of #4647

@yurishkuro yurishkuro closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant