Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query service fails without static assets #497

Closed
yurishkuro opened this issue Oct 28, 2017 · 4 comments
Closed

Query service fails without static assets #497

yurishkuro opened this issue Oct 28, 2017 · 4 comments

Comments

@yurishkuro
Copy link
Member

This was introduced in #490.

I was debating it with @black-adder. The xdock was failing and the options were:

  1. skip static handler if no static assets are found
  2. create dummy index.html for xdock
  3. introduce a new cmd line switch that explicitly disables static handler

Option (1) was the behavior before this change, but we've seen complaints about it before as a misconfiguration would go unnoticed until you try accessing the UI. We went with the simplest solution (2), but my preference is to do (3).

@pavolloffay
Copy link
Member

pavolloffay commented Oct 29, 2017

I think there is also alternative to 3) simply disable static handler if --query.static-files is empty. By default it is set to jaeger-ui-build/whatever.

It is basically I have done in #493

@yurishkuro
Copy link
Member Author

don't have a strong objection to that either, but it means all-in-one cannot be run with a simple command anymore

@pavolloffay
Copy link
Member

don't have a strong objection to that either, but it means all-in-one cannot be run with a simple command anymore

Isn't that expected? (Option (1) was the behavior before this change, but we've seen complaints about it before as a misconfiguration would go unnoticed until you try accessing the UI.)

If a new flag is introduced it would require it too (to start without static assets).

@pavolloffay
Copy link
Member

done in #493 -- Empty --query.static-files disables static handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants