Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guaranteed throughput samplers should report the actual lower bound in the tags #5

Open
4 tasks
yurishkuro opened this issue Nov 29, 2016 · 3 comments
Open
4 tasks

Guaranteed throughput samplers should report the actual lower bound in the tags #5

yurishkuro opened this issue Nov 29, 2016 · 3 comments

Comments

@yurishkuro
Copy link
Member

Currently several implementations are reporting tags sampling.type=lowerbound, sampling.param=$rate when lower bound sampler is triggered, where $rate is the sampling rate of the probabilistic sampler. We should change it to report the actual lower bound value, for consistency.

  • Node client
  • Go client
  • Python client
  • Java client
@yurishkuro
Copy link
Member Author

@black-adder are you doing this?

@jpkrohling
Copy link
Contributor

Is this still relevant?

@yurishkuro
Copy link
Member Author

it is, but low priority

@judyQD judyQD mentioned this issue Apr 26, 2021
Open
@peacedevil13 peacedevil13 mentioned this issue Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @yurishkuro