Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default time span of ES index configurable #628

Closed
yurishkuro opened this issue Jan 2, 2018 · 2 comments
Closed

Make default time span of ES index configurable #628

yurishkuro opened this issue Jan 2, 2018 · 2 comments
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Right now ES storage rotates indices every 24hrs because of this code in es span writer:

func indexNames(span *model.Span) (string, string) {
	spanDate := span.StartTime.Format("2006-01-02")
	return spanIndexPrefix + spanDate, serviceIndexPrefix + spanDate
}

It would be better to have a CLI flag to configure the time span of the index, and truncate span.StartTime to that granularity.

@pavelnikolov
Copy link

@yurishkuro I would also suggest allowing custom format.

At the moment all time based indices that we have in our ES clusters are named like <index-name>_YYYY.MM.DD. And we have a single cronjob which deletes indices with data older than some configured number of days. Jaeger indices are the only exception to this naming convention and we have to run/maintain a separate cronjob just for Jaeger. Not a big deal, but it's a little annoying : )

@pavolloffay
Copy link
Member

Please see #840 and rollover api issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants