Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vote] Promote jpkrohling to full maintainer #849

Closed
yurishkuro opened this issue May 28, 2018 · 8 comments
Closed

[vote] Promote jpkrohling to full maintainer #849

yurishkuro opened this issue May 28, 2018 · 8 comments
Assignees
@yurishkuro

Comments

@yurishkuro
Copy link
Member

@jaegertracing/jaeger-maintainers
@yurishkuro
Copy link
Member Author

cc @jpkrohling

@black-adder
Copy link
Collaborator

+1

2 similar comments
@pavolloffay
Copy link
Member

+1

@vprithvi
Copy link
Collaborator

+1

@yurishkuro
Copy link
Member Author

Done. Congrats! 🎉 🎈🎈🎈🎈🎈

@jpkrohling
Copy link
Contributor

Thanks for the trust!

@caniszczyk
Copy link
Contributor

Awesome, are the maintainers listed anywhere in public?

should CODEOWNERS be updated? also formatting looks wrong here:
https://github.com/jaegertracing/jaeger/blob/master/CODEOWNERS

@yurishkuro yurishkuro reopened this May 29, 2018
@yurishkuro yurishkuro mentioned this issue May 29, 2018
Merged
@ghost ghost assigned yurishkuro May 29, 2018
@ghost ghost added the review label May 29, 2018
@yurishkuro
Copy link
Member Author

@caniszczyk what's wrong with the format? Looks correct per https://help.github.com/articles/about-codeowners/

I added a PR to update it and add a section to README.

@ghost ghost removed the review label May 29, 2018
@yurishkuro yurishkuro changed the title [vote] Add jpkrohling as a maintainer [vote] Promote jpkrohling to full maintainer Nov 2, 2018
@yurishkuro yurishkuro mentioned this issue Nov 2, 2018
Merged
@jpkrohling jpkrohling mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpkrohling @caniszczyk @black-adder @vprithvi @yurishkuro @pavolloffay