Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration consistency with other jaeger components #85

Open
naseemkullah opened this issue Mar 12, 2020 · 1 comment
Open

configuration consistency with other jaeger components #85

naseemkullah opened this issue Mar 12, 2020 · 1 comment

Comments

@naseemkullah
Copy link
Member

naseemkullah commented Mar 12, 2020

Hello @pavolloffay @yurishkuro @jpkrohling

Requirement - what kind of business use case are you trying to solve?

Trying to reuse config across various jaeger components. Works quite well except for schema, spark-job and es-index-cleaner components. This issue is to address the inconsistencies with spark. A separate issue was opened to address es index cleaner but "closed as wont-fix": jaegertracing/jaeger#2124.

Problem - what in Jaeger blocks you from solving the requirement?

example:
spark-job -> ES_NODES, CASSANDRA_CONTACT_POINTS
other components -> ES_SERVER_URLS, CASSANDRA_SERVERS

Proposal - what do you suggest to solve the problem or improve the existing situation?

Keep environment variable names consistent with main components (collector, query, ingester)

@jpkrohling
Copy link

I'm all for naming consistency, especially if they follow the same syntax (comma-separated URL values, host:port, ...) and have the same semantics. I think @pavolloffay mentioned that some values might not be consistent, so, I think the first step would be to map all the vars and their values. We can then map and decide whether we want to rename the properties. In the end, it should also be clear whether we might end up with name clashes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants