New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review morning session Awesome books #2

Open

williamscch opened this issue Jul 5, 2022 · 3 comments

williamscch commented Jul 5, 2022

No description provided.

DiegoMero commented Jul 5, 2022

Highlights

Nice use of the libraries in Javascript.

Changes

Kindly try to put the footer at the bottom of the page.

Krishnabot commented Jul 5, 2022

Great project! precisely refactored and used JS modules. 👍👍👍

Author

williamscch commented Jul 5, 2022

In the Html is not necessary to import the whole scripts from your modules, it will be enough importing just the script file where all the functions and classes work together.
That is a great job, Great use of the luxon library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment