Fix #28: Remove = and not= from Numbers/Compare, and == from Misc/Com…

…pare
clojure · Feb 3, 2015 · f8a3b3a · f8a3b3a
1 parent 6daa7c9
commit f8a3b3a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/clj-jvm/CHANGELOG.txt b/src/clj-jvm/CHANGELOG.txt
@@ -1,3 +1,16 @@
+----------------------------------------------------------------------
+Feb TBD, 2015 - Clojure 1.3 - 1.6, sheet v22
+
+Remove = and not= from Numbers/Compare section.  It already has ==,
+which is more appropriate for comparing numeric values than =, because
+of the cross-type comparisons where = always returns false, and not=
+always returns true, e.g. float/double vs. any integral type,
+float/double vs. BigDecimal, any integral type vs. BigDecimal.
+
+Remove == from Misc/Compare section since it is already in
+Numbers/Compare section, and is redundant and perhaps confusing in
+Misc section.
+
 ----------------------------------------------------------------------
 Feb 3, 2015 - Clojure 1.3 - 1.6, sheet v21
 

diff --git a/src/clj-jvm/src/generator/core.clj b/src/clj-jvm/src/generator/core.clj
@@ -153,7 +153,7 @@
                                           ]]
                       ["Arithmetic" :cmds '[+ - * / quot rem mod inc dec
                                             max min +' -' *' inc' dec']]
-                      ["Compare" :cmds '[= == not= < > <= >= compare]]
+                      ["Compare" :cmds '[== < > <= >= compare]]
                       ["Bitwise" :cmds '[[:common-prefix bit- and or xor not
                                           flip set shift-right shift-left
                                           and-not clear test]
@@ -398,7 +398,7 @@
                          {:latex "\\textmd{\\textsf{Note: always use return value for later changes, never original!}}",
                           :html "Note: always use return value for later changes, never original!"}]]]
               :subsection "Misc"
-              :table [["Compare" :cmds '[= == identical? not= not compare
+              :table [["Compare" :cmds '[= identical? not= not compare
                                          clojure.data/diff]]
                       ["Test" :cmds '[true? false? instance? nil?
                                       "(1.6)" some?]]]