Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for JOSS paper #225

Closed
srmnitc opened this issue Feb 9, 2024 · 4 comments · Fixed by #226
Closed

Suggestions for JOSS paper #225

srmnitc opened this issue Feb 9, 2024 · 4 comments · Fixed by #226

Comments

@srmnitc
Copy link

srmnitc commented Feb 9, 2024

Here are some suggestions for the JOSS paper:

  • citation for LOBSTER
  • are there any tools similar to lobsterpy in the community?
@RMeli RMeli mentioned this issue Feb 9, 2024
Closed
@RMeli
Copy link
Contributor

RMeli commented Feb 9, 2024

Related to openjournals/joss-reviews#6286.

@naik-aakash naik-aakash mentioned this issue Feb 9, 2024
Merged
@JaGeo
Copy link
Owner

JaGeo commented Feb 9, 2024

@srmnitc , @naik-aakash and I have addressed your comments in #226 . Are you fine with the changes?

@srmnitc
Copy link
Author

srmnitc commented Feb 9, 2024

@JaGeo Thanks, everything looks good to me!

@JaGeo
Copy link
Owner

JaGeo commented Feb 9, 2024

Great, @srmnitc. We will merge then and close this issue (cc @RMeli )

@JaGeo JaGeo closed this as completed in #226 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

address review comments > LOBSTER citation, similar packages JaGeo/LobsterPy
3 participants
@RMeli @srmnitc @JaGeo