Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing on-going Giveaways #58

Open
MichailiK opened this issue Oct 24, 2020 · 2 comments
Open

Editing on-going Giveaways #58

MichailiK opened this issue Oct 24, 2020 · 2 comments

Comments

@MichailiK
Copy link
Contributor

In the Discord Giveaways's #support channel, it's been asked many, many times to edit on-going Giveaways. Perhaps this should become a feature.
I can see the disadvantages of editing Giveaways though, especially when editing them shortly before they end. Perhaps it's possible to allow users to edit a Giveaway for a few (10-15) minutes after creation?
This could become an interesting discussion...

@Sanduhr32
Copy link
Contributor

This would not be hard at all.
I still feel like users should make up what they give away before creating a giveaway. They also should double check the data they enter.

While we are at feature things, many people also ask for translation.
And as a side note, parsing time formats like 4d3h is implemented but never used / supported. I might also want to change that.

@jagrosh
Copy link
Owner

jagrosh commented Oct 26, 2020

There are 3 primary reasons why this hasn't been added:

  1. Because giveaways are updated in a separate process from where they are set up, giveaways might not show their updated information for a significant period of time, or the two processes could end up competing to edit the message. Editing the end time of a giveaway could also negatively impact the internal 'status' of a giveaway.
  2. Users could end up entering a giveaway they don't want (or weren't expecting) as the contents could end up changing after they have entered. User consistency is an important consideration in all features.
  3. Editing the time of a giveaway could end up being syntactically confusing; using duration is already a struggle for some users (as opposed to using specific date times), but is currently used because duration is timezone-independent.

That said, if a solution was found that addresses these concerns, I think it would be a feasible addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants