Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Shapes Zoom in Previews Does Not Match Device Zoom #258

Closed
2 tasks done
bkazoo opened this issue Jan 30, 2021 · 2 comments
Closed
2 tasks done

Icon Shapes Zoom in Previews Does Not Match Device Zoom #258

bkazoo opened this issue Jan 30, 2021 · 2 comments

Comments

@bkazoo
Copy link

bkazoo commented Jan 30, 2021

  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version.

Device/App info:

  • Blueprint Version: 2.1.6
  • Android version: 10
  • Device Manufacturer: Nokia
  • Device Name: 7 plus

Describe the bug

In adaptive icons, selecting an Icon Shape other than 'Set by System' applies a mask that does not respect the real icon sizes in the preview.
For example, if the device is using circle shape for the icons, Blueprint 'Set by System' icon shape will show a circle with the exact same size/zoom for the adaptive icons in the icons preview. Setting Blueprint to 'Circle' shape will make the foreground a little bit smaller (showing more of it) and not match the expected sizes.

I have reproduced this issue in several devices. All adaptive shapes other than 'Set by System' are a little bit off.

Reproduction Steps

  1. Using an icon pack that has adaptive icons, select 'Set by System' icon shape in Blueprint. For the screenshots, a 108dp*108dp icon with a 72dp*72dp gray square and red background is used.
  2. Change the icon shape to that shape, but instead of 'Set by System', select the actual shape. For example, if the system shape is a circle, select 'Circle' as icon shape.
  3. Compare icons preview.

Expected behavior

The icons size/zoom should match the ones from the system and the Android sizes, like those described here: https://medium.com/google-design/designing-adaptive-icons-515af294c783

Screenshots

Red should not be shown in any shape:
Capture

'Set by System' shape in Blueprint (OK):
system

'Circle' shape in Blueprint:
circle

'Square' shape in Blueprint:
square

@welcome
Copy link

welcome bot commented Jan 30, 2021

Thanks for opening your first issue here 😃! Please be sure to follow the issue template and check the contribution guidelines 😉 (otherwise the issue will be ignored 😕).

@sarsamurmu
Copy link

The problem has been fixed in AdaptiveIconBitmap version 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants