Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Ability to name icons properly #20

Closed
2 tasks done
dodekaphilist opened this issue Feb 10, 2018 · 4 comments
Closed
2 tasks done

[REQUEST] Ability to name icons properly #20

dodekaphilist opened this issue Feb 10, 2018 · 4 comments

Comments

@dodekaphilist
Copy link

  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version of Blueprint.
Device/dashboard info:
  • Blueprint version: 1.0.8
  • Device OS version: 8.0
  • Device: Pixel Emulator

Current behaviour:
Name of file is taken, underscores are replaced by blank and next character is made upper-case.

Problem:
Apps like 9GAG start with a number, which isn't allowed, and usecapital letter only.
Apps like Öffi use characters, that are not allowed at all.

screenshot_1518279690

Solution:
Ability to name icons properly, maybe also support internationalisation, as there are
apps like Google Keep have a different name e.g. where I live

@jahirfiquitiva
Copy link
Owner

jahirfiquitiva commented Feb 10, 2018

The current approach is designed this way to ease the work.
Many people just want to put the icons and do the less possible effort/work to get their icon pack working.

Icons names are the same as the PNGs due to the reason above and I won't change this behavior because it only complicates things for both designers and me.

About certain characters not allowed, that's an android system limitation, not my own decision

@dodekaphilist
Copy link
Author

The character limitation is a direct consequence that names come from an array with the file names. Giving file names and names displayed separately would solve that, not sure how difficult it would be to implement that though.
I even thought about writing a script or something where everything important is put in, so ComponentInfo, file name and display name. Because this is the task most annoying to put the icon pack information in the corresponding files like icon_pack.xml, appfilter.xml or appmap.xml whereas the stuff itself is nearly the same. My coding skills are not enough for that, I'm afraid.

@jahirfiquitiva
Copy link
Owner

@dashlabsdeveloper

Yeah, as I told you it would just increase the work for designers, having to define the name of the icon and the name of the file.

Sorry, but I won't change the current behavior. You're honestly the first (and probably the only) one to be concerned about the icon names in the app

@lock
Copy link

lock bot commented Feb 17, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants