Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student Folder method/property rework #3

Closed
jahorton opened this issue Dec 5, 2017 · 0 comments · Fixed by #13
Closed

Student Folder method/property rework #3

jahorton opened this issue Dec 5, 2017 · 0 comments · Fixed by #13

Comments

@jahorton
Copy link
Owner

jahorton commented Dec 5, 2017

Some of the currently existing build warnings will be fairly difficult to fix without some minor changes to code organization for the StudentData class and its interactions with the LMSAssignmentManager interface. In particular, the isStudentFolderPresent method is part of the LMSAssignmentManager.

  • Both StudentData and LMSAssignmentManager are generic and have related type parameters.
  • Many uses of LMSAssignmentManager should be LMSAssignmentManager<?> - wildcarded.
    • This causes serious conflicts with attempts to wildcard StudentData... which should probably not be generic at all.

As a result, LMSAssignmentManager.isStudentFolderPresent should be reworked to StudentData.getStudentFolder. The LMSDataTag inner class/interface of LMSAssignmentManager could prove useful in rerouting the important functionality to facilitate this restructure.


Alternatively, if it is possible to reasonably preserve the current generic specifications while being more precise in their use, that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant