New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method URLPattern.getPatternDepth always returns 1 and does not throw on // #93

Closed

pzygielo opened this issue Sep 3, 2020 · 1 comment

Contributor

pzygielo commented Sep 3, 2020

As shown in #92, in the method
https://github.com/eclipse-ee4j/authorization/blob/6d88b79d72142139716c954aca2d8a0ecbc68784/api/src/main/java/jakarta/security/jacc/URLPattern.java#L181-L200

local variable depth is never modified,
with that, condition at line 191 is always false and IAEx is not thrown and:
https://github.com/eclipse-ee4j/authorization/blob/7925d26a9988f8d2d7893ce57e8a462c643b3cfc/api/src/test/java/jakarta/security/jacc/URLPatternTest.java#L50 passes,
with above this method always returns value of 1, after wasting time in while loop 😞 (and the remaining tests pass).

I might be wrong in my assessment, but for me there is bug there.

The text was updated successfully, but these errors were encountered:

Contributor Author

pzygielo commented Jul 25, 2021

Closing due to inactivity.

pzygielo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment