Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JSR 352 references to properties and job XML targetNamespace (if necessary) #12

Closed
2 tasks done
scottkurz opened this issue Mar 7, 2020 · 13 comments
Closed
2 tasks done

Comments

@scottkurz
Copy link
Contributor

scottkurz commented Mar 7, 2020

Need to do:

  • spec-defined properties move from javax. to jakarta.* (along w/ packages)
  • the targetNamespace for the Batch XML / XSD change (currently using   targetNamespace="http://xmlns.jcp.org/xml/ns/javaee").

Brought up discussion here.

@scottkurz
Copy link
Contributor Author

Per: jakartaee/platform#161

the TNS is tracked via this bug.

@scottkurz
Copy link
Contributor Author

The properties aspect was addressed via #11

@teobais
Copy link
Contributor

teobais commented Mar 14, 2020

Shall we then strikethrough the properties bullet above? It might be helpful for newcomers :-)

@scottkurz
Copy link
Contributor Author

Shall we then strikethrough the properties bullet above? It might be helpful for newcomers :-)

I tried the checkbox, maybe the strikethrough would have been more visible.

@scottkurz
Copy link
Contributor Author

From today's EE Platform meeting notes.

Decided:

  1. Batch will keep ownership of our two XSD files (batch.xml, job xml)
    • We will rename the files to follow convention including version number
  2. Namespace will change (as in the issue 592 linked above)
    http://xmlns.jcp.org/xml/ns/javaee ->
    https://jakarta.ee/xml/ns/jakartaee
  3. No concern about sharing target namespace with non-batch elements.
  4. We will publish them on the Jakarta website via PR to the appropriate project (didn't catch which one exactly).
  5. We will follow-up and look into what our story was for Jakarta EE 8, either explaining it or even just rationalizing and understanding if we did not package this within our API JAR.

@scottkurz
Copy link
Contributor Author

Or should we carve out our own NS with an extra qualifier?

https://jakarta.ee/xml/ns/jakartaee/batch

It's not that I think there's any document that would include other elements in this NS... but what if there's a tool or what if it matters for some unforseen reason, well, this would be the time to change.

@teobais
Copy link
Contributor

teobais commented Mar 24, 2020

How are other specs gonna proceed on this one?

My take would be to indeed go for https://jakarta.ee/xml/ns/jakartaee/batch , given that it's a more discrete one and the chances to change that in the future are much less compared to a generic namespace used by everyone.

But this is only my gut feeling, as I have no prior experience with namespaces administration.

@scottkurz
Copy link
Contributor Author

scottkurz commented Mar 29, 2020

From ML discussion, we will go with (the common) namespace of :
https://jakarta.ee/xml/ns/jakartaee

@teobais
Copy link
Contributor

teobais commented Mar 30, 2020

Cool! Looking forward to it.

@teobais
Copy link
Contributor

teobais commented Mar 30, 2020

@scottkurz I guess that implies we can proceed with the necessary changes on #15 .

Will look into it this week

@teobais
Copy link
Contributor

teobais commented Mar 30, 2020

From ML discussion, we will go with (the common) namespace of :
https://jakarta.ee/xml/ns/jakartaee/batch

@scottkurz I just noticed that you're talking about https://jakarta.ee/xml/ns/jakartaee/batch , whereas in the ML discussion that I just read through, https://jakarta.ee/xml/ns/jakartaee is mentioned, so I just guess it was a typo :-)

If that's indeed the case, then there's no need to adjust #15 . #15 is ready to be merged

@scottkurz
Copy link
Contributor Author

Whoops, yeah https://jakarta.ee/xml/ns/jakartaee/batch was a typo.. I corrected the comment and merged #15. Thanks.

@scottkurz
Copy link
Contributor Author

This is complete. Schema update moved to #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants