Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter of @SkipIfPortableExtensionPresent should have type Class #585

Closed
manovotn opened this issue Jan 4, 2022 · 2 comments · Fixed by #586
Closed

The parameter of @SkipIfPortableExtensionPresent should have type Class #585

manovotn opened this issue Jan 4, 2022 · 2 comments · Fixed by #586
Assignees
Labels
Lite Related to CDI Lite

Comments

@manovotn
Copy link
Contributor

manovotn commented Jan 4, 2022

I am referring to this annotation.

Currently, it has a parameter of type String which makes it rather inconvenient to use as you need to spell the whole FQCN. The ability to use Class instead would make it way easier.

Now, I am not sure if we chose String for some specific purpose so please do jump in and tell me if you recall that. But thinking on it some more, this annotation is only ever used in CDI Full where portable extension and build compatible extension co-exist so it shouldn't be blocking any build oriented approach when we use Class parameter.

@manovotn manovotn added the Lite Related to CDI Lite label Jan 4, 2022
@manovotn manovotn self-assigned this Jan 4, 2022
@manovotn
Copy link
Contributor Author

manovotn commented Jan 4, 2022

@graemerocher was this any kind of requirement from MN side that I had forgotten?
(Although I think MN won't actually use this annotation at all, right?)

@Ladicek
Copy link
Contributor

Ladicek commented Jan 5, 2022

We discussed this yesterday on the CDI call and if I remember correctly, there were no objections to making the member Class-typed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lite Related to CDI Lite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants