-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify handling exceptions during async events #599
Comments
I agree that we should get rid of the word "multiple" in the name of the section, but " |
@Ladicek I see it the same way but in the least we should add a TCK test that asserts it. I have create all the needed issues so it hopefully won't be forgotten :) |
Yea totally agree about the TCK. |
Does this require another respin of the release? If yes, I will need to withdraw the ballot again. please let me asap. |
No as this is not a new issue. It is simply additional test coverage that can be rolled into the next TCK update. |
The specification has a chapter on this but it is IMO not entirely clear because it only covers the case where more than one exception is thrown.
The TCK likewise only covers such scenario, see https://github.com/eclipse-ee4j/cdi-tck/tree/master/impl/src/main/java/org/jboss/cdi/tck/tests/event/observer/async/handlingExceptions
We should change the chapter title to something like
Handling exceptions thrown during an asynchronous event
and in the text we need to either explicitly state that the cause is alwaysCompletionException
or just mention what happens in case there is only one exception.Afterwards, we should add a TCK test for it.
Note that this was originally brought up in Quarkus issue - quarkusio/quarkus#24646
The text was updated successfully, but these errors were encountered: