Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbolic constants for many context-param values #1132

Closed
eclipse-faces-bot opened this issue Aug 22, 2012 · 6 comments
Closed

Missing symbolic constants for many context-param values #1132

eclipse-faces-bot opened this issue Aug 22, 2012 · 6 comments

Comments

@eclipse-faces-bot
Copy link

Many of the context-param values introduced in JSF 2.0 appear in Mojarra as literal strings. This is error prone. There should be symbolic constants for every context-param in the section "Application Configuration Parameters" in the spec prose document.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by @edburns

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
While fixing this, I noticed a cut and paste error in the spec prose document.

The normative text in the "Application Configuration Parameters" section in the spec prose document for

javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER

has an incorrectly inserted cross reference.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
SECTION: Modified Files

M test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java
M test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java

  • re-enable these since I can't get them to fail locally. I'll
    re-disable them if they fail and go back to the drawing board.

M jsf-api/src/main/java/javax/faces/application/ViewHandler.java
M jsf-api/src/main/java/javax/faces/application/StateManager.java
M jsf-api/src/main/java/javax/faces/convert/Converter.java

  • Add symbolic constants

M jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java

  • Replace literal strings with symbolic constants
    Authentication realm: <https://svn.java.net:443> Subversion Repository
    Username: edburns
    Password for 'edburns':
    Sending jsf-api/src/main/java/javax/faces/application/StateManager.java
    Sending jsf-api/src/main/java/javax/faces/application/ViewHandler.java
    Sending jsf-api/src/main/java/javax/faces/convert/Converter.java
    Sending jsf-ri/src/main/java/com/sun/faces/config/WebConfiguration.java
    Sending test/agnostic/lifecycle/unserializableServerState_negative/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_negative/Issue1127IT.java
    Sending test/agnostic/lifecycle/unserializableServerState_positive/src/test/java/com/sun/faces/test/agnostic/lifeycle/unserializableServerState_positive/Issue1127IT.java
    Transmitting file data ......
    Committed revision 10507.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Thursday, August 23rd 2012, 7:23:14 pm

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1132

@eclipse-faces-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant