ExternalContext.dispatch Javadocs Should Match Implementation #1136
Assignees
Milestone
Comments
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
@glassfishrobot Commented |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the Javadocs for ExternalContext.dispatch method say:
@throws IllegalArgumentException if no request dispatcher
@throws NullPointerException if
pathnullHowever the implementation does this:
RequestDispatcher requestDispatcher = request.getRequestDispatcher(
requestURI);
if (requestDispatcher == null)
{ ((HttpServletResponse) response). sendError(HttpServletResponse.SC_NOT_FOUND); return; }
The servlet specification indicates that a null RequestDispatcher will be returned if one cannot be created (for example by passing in a null argument to request.getRequestDispatcher). The JavaDocs for ExternalContextDispatcher should be changed as follows:
1. remove throws IllegalArgumentException, NullpointerException verbage.
2. add "If the call to
getRequestDisatcher(path)returns null, send aServletResponse SC_NOT_FOUNDerror code.Affected Versions
[2.2]
The text was updated successfully, but these errors were encountered: