Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate #1215

Closed
eclipse-faces-bot opened this issue Aug 12, 2013 · 9 comments
Closed

Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate #1215

eclipse-faces-bot opened this issue Aug 12, 2013 · 9 comments
Labels
Component: Facelets/VDL Priority: Critical Type: Bug
Milestone
2.3

Comments

@eclipse-faces-bot
Copy link

The current spec has no javadoc for DelegatingMetaTagHandler.getTagHandlerDelegate(). [1] This issue proposes adding the following warning to the javadoc for this method.

Code that extends from DelagatingMetaTagHandler (directly or indirectly, as through extending ComponentHandler) must take care to decorate, not replace, the TagHandlerDelegate instance returned by this method. Failure to do so may produce unexpected results.

[1] http://docs.oracle.com/javaee/6/api/javax/faces/view/facelets/DelegatingMetaTagHandler.html#getTagHandlerDelegate%28%29

Affected Versions

[2.0, 2.1, 2.2]
@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by @edburns

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Setting priority to Critical

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle.txt
Attached By: @manfredriem

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Applied to 2.3 trunk,

svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1215, Add warning to javadoc of DelegatingMetaTagHandler.getTagHandlerDelegate"
Sending jsf-api/src/main/java/javax/faces/view/facelets/DelegatingMetaTagHandler.java
Transmitting file data .
Committed revision 15006.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Friday, August 14th 2015, 7:12:26 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle.txt
Attached By: @manfredriem

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1215

@eclipse-faces-bot
Copy link
Author

@eclipse-faces-bot eclipse-faces-bot added this to the 2.3 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Facelets/VDL Priority: Critical Type: Bug
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
1 participant
@eclipse-faces-bot