Inconsistent exception handling for phaselisteners

[eclipse-faces-bot]

Exception handling for phase listeners behaves differently depending on if they are registered globally in faces-config.xml or with f:phaseListener for a particular view root.

In the first (global) case any exception thrown by them gets forwarded to an exception handler as described in the spec.

In the second (per view root) case all exceptions get logged and swallowed as described in the UIViewRoot documentation.

This inconsistent behavior adds increased complexity when implementing PhaseListeners. Ideally both cases should forward any exception to the exception handler so they can be handled there.

See also the discussion of the problem in: https://java.net/jira/browse/JAVASERVERFACES-2985

Affected Versions

[2.1, 2.2]

[eclipse-faces-bot]

@glassfishrobot Commented
Reported by frederickkaempfer

[eclipse-faces-bot]

@glassfishrobot Commented
Issue-Links:
is related to
JAVASERVERFACES-4054

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

[eclipse-faces-bot]

@glassfishrobot Commented
pnicoluc said:
Proposed solution:

http://docs.oracle.com/javaee/7/api/javax/faces/component/UIViewRoot.html#encodeBegin-javax.faces.context.FacesContext-

Update UIViewRoot.encodeBegin(FacesContext context) javadoc by removing the
following text:

"Any errors that occur during invocation of any of the the beforePhase
listeners must be logged and swallowed."

Update UIViewRoot.encodeEnd(FacesContext context) javadoc by removing the
following text:

"Any errors that occur during invocation of the afterPhase
listener must be logged and swallowed. "

Then an update to the implementation would need to be made to publish the
exceptions being thrown by the beforePhase and afterPhase of the
PhaseListeners rather than having them logged and swallowed.

[eclipse-faces-bot]

@glassfishrobot Commented
Marked as fixed on Tuesday, September 8th 2015, 10:38:18 am

[eclipse-faces-bot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1216

[eclipse-faces-bot]

• Issue Imported From: Inconsistent exception handling for phaselisteners  javaee/javaserverfaces-spec#1216
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @edburns
• Original Issue Closed By:@glassfishrobot