Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let CDI handle #{flowScope} #1386

Closed
eclipse-faces-bot opened this issue Jul 30, 2015 · 14 comments
Closed

Let CDI handle #{flowScope} #1386

eclipse-faces-bot opened this issue Jul 30, 2015 · 14 comments
Assignees
@arjantijms
Labels
Priority: Critical Type: Improvement
Milestone
2.3

Comments

@eclipse-faces-bot
Copy link

Let CDI handle #{flowScope}
@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by @arjantijms

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Issue-Links:
blocks
JAVASERVERFACES_SPEC_PUBLIC-1315

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle.txt
Attached By: @arjantijms

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: newfiles.zip
Attached By: @arjantijms

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
If you can fix Javadoc copy-paste error ("SessionMap") then r=mriem

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@arjantijms said:
copy/paste error fixed and committed to 2.3 trunk:

svn commit -m "https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1386, CDI producer for #

{flowScope}

, r=mriem"
Adding jsf-api/src/main/java/javax/faces/annotation/FlowMap.java
Sending jsf-ri/src/main/java/com/sun/faces/cdi/CdiExtension.java
Adding jsf-ri/src/main/java/com/sun/faces/cdi/FlowMapAnnotationLiteral.java
Adding jsf-ri/src/main/java/com/sun/faces/cdi/FlowMapProducer.java
Sending jsf-ri/src/main/java/com/sun/faces/flow/FlowCDIContext.java
Adding test/javaee8/cdi/src/main/java/com/sun/faces/test/javaee8/cdi/InjectFlowMapBean.java
Adding test/javaee8/cdi/src/main/java/com/sun/faces/test/javaee8/cdi/InjectFlowMapBeanX.java
Sending test/javaee8/cdi/src/main/webapp/WEB-INF/web.xml
Adding test/javaee8/cdi/src/main/webapp/flow
Adding test/javaee8/cdi/src/main/webapp/flow/flow-flow.xml
Adding test/javaee8/cdi/src/main/webapp/flow/flow.xhtml
Adding test/javaee8/cdi/src/main/webapp/flow/next.xhtml
Adding test/javaee8/cdi/src/main/webapp/flowx
Adding test/javaee8/cdi/src/main/webapp/flowx/flowx-flow.xml
Adding test/javaee8/cdi/src/main/webapp/flowx/flowx.xhtml
Adding test/javaee8/cdi/src/main/webapp/flowx/next.xhtml
Adding test/javaee8/cdi/src/main/webapp/injectFlowMap.xhtml
Adding test/javaee8/cdi/src/test/java/com/sun/faces/test/javaee8/cdi/Spec1386IT.java
Sending test/javaee8/el/src/main/webapp/WEB-INF/web.xml
Adding test/javaee8/el/src/main/webapp/flow
Adding test/javaee8/el/src/main/webapp/flow/flow-flow.xml
Adding test/javaee8/el/src/main/webapp/flow/flow.xhtml
Adding test/javaee8/el/src/main/webapp/flow/next.xhtml
Adding test/javaee8/el/src/main/webapp/flowMap.xhtml
Adding test/javaee8/el/src/main/webapp/flowx
Adding test/javaee8/el/src/main/webapp/flowx/flowx-flow.xml
Adding test/javaee8/el/src/main/webapp/flowx/flowx.xhtml
Adding test/javaee8/el/src/main/webapp/flowx/next.xhtml
Adding test/javaee8/el/src/test/java/com/sun/faces/test/javaee8/el/Spec1386IT.java
Transmitting file data .........................
Committed revision 15033.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle-tmp-workaround.txt
Attached By: @arjantijms

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@arjantijms said:
Tmp change of EL name to avoid since clash, since even producers are not totally deactivated and still present now.

Applied to 2.3 trunk:

svn commit -m "https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1386, Temp EL name change to fix tests, r=mriem"
Sending jsf-ri/src/main/java/com/sun/faces/cdi/FlowMapProducer.java
Sending test/javaee8/el/src/main/webapp/flow/flow.xhtml
Sending test/javaee8/el/src/main/webapp/flow/next.xhtml
Sending test/javaee8/el/src/main/webapp/flowx/flowx.xhtml
Sending test/javaee8/el/src/main/webapp/flowx/next.xhtml
Transmitting file data .....
Committed revision 15036.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle-rev-workaround.txt
Attached By: @arjantijms

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Looks good r=mriem

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@arjantijms said:
Revert temporary changes again since underlying bug now fixed.

Applied to 2.3 trunk:

svn commit -m "https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1386, revert Temp EL name changes, r=mriem"
Sending jsf-ri/src/main/java/com/sun/faces/cdi/FlowMapProducer.java
Sending test/javaee8/el/src/main/webapp/flow/flow.xhtml
Sending test/javaee8/el/src/main/webapp/flow/next.xhtml
Sending test/javaee8/el/src/main/webapp/flowx/flowx.xhtml
Sending test/javaee8/el/src/main/webapp/flowx/next.xhtml
Transmitting file data .....
Committed revision 15136.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Tuesday, September 15th 2015, 7:19:50 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1386

@eclipse-faces-bot
Copy link
Author

@eclipse-faces-bot eclipse-faces-bot added this to the 2.3 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjantijms arjantijms

Labels
Priority: Critical Type: Improvement
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@arjantijms @eclipse-faces-bot