Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing module-info.java leading to nasty warnings from compiler plugin #1815

Closed
lprimak opened this issue May 30, 2023 · 13 comments · Fixed by #1903
Closed

Missing module-info.java leading to nasty warnings from compiler plugin #1815

lprimak opened this issue May 30, 2023 · 13 comments · Fixed by #1903
Assignees

Comments

@lprimak
Copy link

lprimak commented May 30, 2023

The module info file is missing from Faces API Jar, leading to issues with modularized applications:

[WARN] *****************************************************************************************************************************************************************************************************
[WARN] * Required filename-based automodules detected: [jakarta.faces-api-4.0.1.jar]. Please don't publish this project to a public artifact repository! *
[WARN] *****************************************************************************************************************************************************************************************************
@arjantijms
Copy link
Contributor

Thanks for reporting. This is a bug, and the module-info should have been there.

@lprimak
Copy link
Author

lprimak commented Feb 25, 2024

Hey Arjan, can this be fixed before Jakarta EE 11 please? Thank you!

@lprimak
Copy link
Author

lprimak commented Feb 29, 2024

As of jakarta.faces-api-4.1.0-M1.jar this issue is not fixed yet...

@arjantijms
Copy link
Contributor

Thanks for the reminder! This should absolutely be fixed for the upcoming (few days at most) M2 release.

@arjantijms
Copy link
Contributor

@lprimak If you want, please look at #1903

Would be great if you test it with your code.

@arjantijms arjantijms linked a pull request Mar 6, 2024 that will close this issue
@lprimak
Copy link
Author

lprimak commented Mar 7, 2024

I’ll try

@lprimak
Copy link
Author

lprimak commented Mar 10, 2024

Is there a pre-build JAR I can use?

@arjantijms
Copy link
Contributor

Is there a pre-build JAR I can use?

Nope, the faces repo doesn't have builds for PRs enabled. Best would be to just build it yourself for now.

@lprimak
Copy link
Author

lprimak commented Mar 11, 2024

I cannot build due to missing API dependencies, that are not in the Eclipse SNAPSHOT repository either.
Any help appreciated, as there are way too many APIs to build on my own (basically all of core + web APIs) :)

@BalusC
Copy link
Member

BalusC commented Mar 12, 2024

I was also facing that annoying problem. All I did was to just locally revert the API versions in pom.xml to the ones actually available in central.

@arjantijms
Copy link
Contributor

Did you try building with -Pstaging?

All the dependencies should be in staging.

@lprimak
Copy link
Author

lprimak commented Mar 12, 2024

ah! I tried with snapshot. I will try with staging

@lprimak
Copy link
Author

lprimak commented Mar 12, 2024

It works. Requires changing requires from jarkarta.faces.api to jakarta.faces and it works correctly. Both compilers, deploys and runs! No warnings.

Thank you!

@lprimak lprimak closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants