tlddocs for f:viewParam missing name attribute

[eclipse-faces-bot]

See <http://www.netbeans.org/issues/show_bug.cgi?id=174945>.

Environment

Operating System: All
Platform: Macintosh

Affected Versions

[2.0]

[eclipse-faces-bot]

@glassfishrobot Commented
Reported by @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
There are actually two errors here.

1. JSP should not have f:viewParam.

2. the Facelet taglibrary docs should have a name attribute for f:viewParam

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Issue: https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=656

SECTION: Modified Files

M jsf-ri/conf/share/facelets_jsf_core.tld

• add required name attribute to f:viewParam

M jsf-ri/conf/share/jsf_core.tld

• remove f:viewParam. Not relevant for JSP

SECTION: Diffs

Index: jsf-ri/conf/share/facelets_jsf_core.tld

====
— jsf-ri/conf/share/facelets_jsf_core.tld (revision 8095)
+++ jsf-ri/conf/share/facelets_jsf_core.tld (working copy)
@@ -1147,6 +1147,18 @@

• Name of the parameter to be created.
• name
• true
• java.lang.String

MethodExpression representing a value change listener method Index: jsf-ri/conf/share/jsf_core.tld =============================================================== ==== — jsf-ri/conf/share/jsf_core.tld (revision 8095) +++ jsf-ri/conf/share/jsf_core.tld (working copy) @@ -575,228 +575,6 @@ * * Used inside of the metada facet * of a view, this tag causes a UIViewParameter * to be attached as metadata for the current view. Because * UIViewParameter extends UIInput * all of the attributes and nested child content for any * UIInput tags are valid on this tag as well.

- * ]]>

• viewParam

• com.sun.faces.taglib.jsf_core.ParameterTag

• JSP

• converter

• false

• javax.faces.convert.Converter

• used as the text of the converter message, replacing any message

• that comes from the converter.]]>

• converterMessage

• false

• java.lang.String

• unique within the closest parent component that is a naming

• container.]]>

• id

• false

• true

• value for this input component.]]>

• required

• false

• boolean

• used as the text of the validation message for the "required"

• facility, if the "required" facility is used.]]>

• requiredMessage

• false

• java.lang.String

• during Process Validations to perform correctness checks on the

• value of this component. The expression must evaluate to a public

• method that takes FacesContext, UIComponent, and Object parameters,

• with a return type of void.]]>

• validator

• false

• void validate(javax.faces.context.FacesContext, javax.faces.component.UIComponent,
  java.lang.Object)

• used as the text of the validator message, replacing any

• message that comes from the validator.]]>

• validatorMessage

• false

• java.lang.String

• value

• false

• java.lang.Object

• MethodExpression representing a value change listener method

• that will be notified when a new value has been set for this

• input component. The expression must evaluate to a public

• method that takes a ValueChangeEvent parameter,

• with a return type of void, or

• to a public method that takes no arguments with a return type

• of void. In the latter case, the method has no way of easily

• knowing what the new value is, but this can be useful in cases

• where a notification is needed that "this value

• changed".

• ]]>

• valueChangeListener

• false

• void valueChange(javax.faces.event.ValueChangeEvent)

• -

• be entered in this field.]]>

• maxlength

• false

• int

• -

• The ValueExpression linking this component to a property in a backing bean

• binding

• false

• javax.faces.component.UIComponent

• -
• -

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Fix checked in.

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
I had to revert the jsp portion of this change, which was to simply remove f:viewParam from the JSP
jsf_core.tld. Even though removing it is the correct thing to do, the TCK signature tests fail without that
tag. I have re-added it and will make a note in the MR changelog.

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
I'm going to re-open this to accomodate additional omissions.

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Created an attachment (id=230)
Fix for 20091028 reopening.

[eclipse-faces-bot]

@glassfishrobot Commented
File: changebundle.txt
Attached By: @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Prepare to delete "spec" subcomponent.

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
cat1

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
vdldoc

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
These are valid 2.0 Rev a issues

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Move to P2

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
take ownership.

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Fixed.

[eclipse-faces-bot]

@glassfishrobot Commented
rogerk said:
changelog

[eclipse-faces-bot]

@glassfishrobot Commented
Marked as fixed on Tuesday, June 22nd 2010, 12:09:15 am

[eclipse-faces-bot]

@glassfishrobot Commented
@manfredriem said:
Closing resolved issue out

[eclipse-faces-bot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-656

[eclipse-faces-bot]

• Issue Imported From: tlddocs for f:viewParam missing name attribute javaee/javaserverfaces-spec#656
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @edburns
• Original Issue Closed By:@glassfishrobot