Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@FlashScoped Flash events required in order to appropriately handle object lifecycle and destruction #766

Closed
eclipse-faces-bot opened this issue Mar 15, 2010 · 15 comments

Comments

@eclipse-faces-bot
Copy link

we need to be consistent w/ the way the JSF scopes are handled. We currently
have these events:

javax.faces.event.PostConstructViewMapEvent
javax.faces.event.PreDestroyViewMapEvent

javax.faces.event.PostConstructCustomScopeEvent
javax.faces.event.PreDestroyCustomScopeEvent

So we definitely need the following events in JSF 2.0 Rev a

javax.faces.event.PostConstructFlashEvent
javax.faces.event.PreDestroyFlashEvent

Also, can we consider adding the @javax.faces.bean.FlashScoped annotation like
(Dan) mentioned in the last EG meeting? I'm not concerned about enhancing the
JSF bean container. We just needs a common annotation for CDI or Spring
integration. We need a common touch point, so we avoid introducing
@org.jboss.seam.faces.context.FlashScoped.

Environment

Operating System: All
Platform: All

Affected Versions

[2.0]

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by lincolnbaxter

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Parent-Task: JAVASERVERFACES_SPEC_PUBLIC-976

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
I agree we need this. Put to 2.1

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
triage

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
importance_large

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
GlassFish 3.1 M6 at the latest.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Move these to 2.2

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
After discussion with the reporter on IRC, we have agreed to these names for the events

PostPutFlashValueEvent
PostKeepFlashValueEvent
PreClearFlashEvent

.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
lincolnbaxter said:
Ok, no need to implement the additional @FlashScoped annotation within JSF. You can drop that part of this request.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Committed to trunk.

Sending jsf-api/src/main/java/javax/faces/context/Flash.java
Adding jsf-api/src/main/java/javax/faces/event/PostKeepFlashValueEvent.java
Adding jsf-api/src/main/java/javax/faces/event/PostPutFlashValueEvent.java
Adding jsf-api/src/main/java/javax/faces/event/PreClearFlashEvent.java
Adding jsf-api/src/main/java/javax/faces/event/PreRemoveFlashValueEvent.java
Sending jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java
Adding jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/model/SessionScopedBean.java
Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java
Adding jsf-ri/systest-per-webapp/flash/web/flash14.xhtml
Sending jsf-ri/systest-per-webapp/flash/web/index.xhtml
Transmitting file data ..........
Committed revision 9437.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Friday, October 28th 2011, 8:54:22 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
On Friday, I noticed that the newly-enhanced flash testcase failed in clustered environments. Upon investigation, I learned that it can't work in a clustered environment, as written. This commit modifies the testcase so that it does work in a clustered environment.

Sending jsf-ri/systest-per-webapp/flash/src/java/com/sun/faces/systest/FlashTestCase.java
Transmitting file data .
Committed revision 9441.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Closing resolved issue out

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-766

@eclipse-faces-bot
Copy link
Author

@eclipse-faces-bot eclipse-faces-bot added this to the 2.2 Sprint 8 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant