Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ResourceWrapper#getContentType() or define resource behaviour for null values #914

Closed
eclipse-faces-bot opened this issue Nov 30, 2010 · 14 comments
Closed

add ResourceWrapper#getContentType() or define resource behaviour for null values #914

eclipse-faces-bot opened this issue Nov 30, 2010 · 14 comments
Assignees
@glassfishrobot
Labels
Component: Components/Renderers Priority: Major Type: Improvement
Milestone
2.1

Comments

@eclipse-faces-bot
Copy link

Component libraries which use the ResouceWrapper but do not explicitely override Resource#getContentType() will cause an undefined content Type (aka null).

So we either also provide delegation for this method in ResourceWrapper() or we define that the resource handler implementation must use the external context to determine the default contentType to use as fallback.

Affected Versions

[2.1]
@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by struberg

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Issue-Links:
blocks
JAVASERVERFACES_SPEC_PUBLIC-917

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Was assigned to dueni

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
I would prefer to go the route of providing delegation in ResourceWrapper - see: http://java.net/jira/browse/JAVASERVERFACES-1879
However, this may be classified as a spec change and therefore we may not be able to get it into 2.1 (but let's see). To speed things up, can you provide a patch for the implementation workaround option?

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
Assign

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
Need to defer to 2.2 since this is a spec change.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
dueni said:
The patch is attached to http://java.net/jira/browse/JAVASERVERFACES-1879

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
This should be done for 2.2

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
rogerk said:
triage

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
dueni said:
This issue was resolved by #917

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Thursday, May 19th 2011, 7:39:17 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Closing resolved issue out

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-914

@eclipse-faces-bot eclipse-faces-bot added this to the 2.1 milestone Aug 6, 2019
@eclipse-faces-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glassfishrobot glassfishrobot

Labels
Component: Components/Renderers Priority: Major Type: Improvement
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@glassfishrobot @eclipse-faces-bot