TCK wrongly test GregorianCalendar

[rmannibucau]

Hi,

Not sure where TCK are but I'd like to report that they likely assume they run on a particular implementation - which is wrong from a spec perspective.

com.sun.ts.tests.jsonb.defaultmapping.dates.DatesMappingTest#testGregorianCalendarWithTimeMapping uses GregorianCalendar#equals to compare serialized and deserialized instances which basically means the way the instance is built - and not its value - is validated. This is likely wrong since JSON-B can only guarantee the value.

[jansupol]

1. The TCK repo is here
2. The test is here
3. Do you refer to b.equals(orig.getTime()) or what equals?

[rmannibucau]

@jansupol yes, the default equals is used for the mentionned test, i.e. com.sun.ts.tests.jsonb.MappingTester#testUnmarshall which just do an equals (no getTime() or so).

[jansupol]

Can you please point to the line in MappingTester?

[rmannibucau]

sure,

https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/jsonb/MappingTester.java#L70 which is used since https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/jsonb/defaultmapping/dates/DatesMappingTest.java#L270 does not override it.

For reference, some other tests fix it: https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/jsonb/defaultmapping/dates/DatesMappingTest.java#L248

[jansupol]

This seems to be the only case using GregorianCalendar. Do the other tests work for you? Can you please file a bug in the TCK issue tracker?

[rmannibucau]

Done at jakartaee/platform-tck#102, thanks for the help @jansupol

[jansupol]

Closing this in favor of the new bug