-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK wrongly test GregorianCalendar #177
Comments
@jansupol yes, the default equals is used for the mentionned test, i.e. com.sun.ts.tests.jsonb.MappingTester#testUnmarshall which just do an equals (no getTime() or so). |
Can you please point to the line in MappingTester? |
This seems to be the only case using GregorianCalendar. Do the other tests work for you? Can you please file a bug in the TCK issue tracker? |
Done at jakartaee/platform-tck#102, thanks for the help @jansupol |
Closing this in favor of the new bug |
Hi,
Not sure where TCK are but I'd like to report that they likely assume they run on a particular implementation - which is wrong from a spec perspective.
com.sun.ts.tests.jsonb.defaultmapping.dates.DatesMappingTest#testGregorianCalendarWithTimeMapping uses GregorianCalendar#equals to compare serialized and deserialized instances which basically means the way the instance is built - and not its value - is validated. This is likely wrong since JSON-B can only guarantee the value.
The text was updated successfully, but these errors were encountered: