Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to "opt out" of CsrfOptions.IMPLICIT #34

Closed
chkal opened this issue Jul 19, 2020 · 5 comments
Closed

Add ability to "opt out" of CsrfOptions.IMPLICIT #34

chkal opened this issue Jul 19, 2020 · 5 comments

Comments

@chkal
Copy link
Contributor

chkal commented Jul 19, 2020

Issue by mvcbot
Sunday Oct 25, 2015 at 19:01 GMT
Originally opened as mvc-spec/mvc-spec#70


Original issue MVC_SPEC-58 created by kito75:

It'd be nice to opt out of implicit CSRF protection, maybe with an annotation like @CsrfValidDisabled,

@chkal
Copy link
Contributor Author

chkal commented Jul 19, 2020

Comment by chkal
Sunday Feb 11, 2018 at 12:43 GMT


I'm not completely sure if this is something we should support. Assigning to "Future" for now. Anyone feel free to comment if you disagree with this decision.

@erdlet
Copy link
Contributor

erdlet commented Oct 23, 2022

Think this is something we should discuss together with #22.

@chkal
Copy link
Contributor Author

chkal commented Oct 29, 2022

Agreed. However, I still don't see a use case for disabling such an important security feature.

@erdlet erdlet removed this from the 3.0 milestone Mar 17, 2023
@erdlet
Copy link
Contributor

erdlet commented Apr 23, 2023

Think we should close this, because of those two reasons:

  • As @chkal mentioned, it is hardly to imagine a use-case that opens a vulnerability on purpose
  • In case there is really a use-case that needs CSRF protection disabled for specific resources, you can achieve this with the combination of CsrfOptions.EXPLICIT and removing the @CsrfProtected annotation on this resource

Any other thoughts?

@chkal
Copy link
Contributor Author

chkal commented Apr 27, 2023

I agree that we should close this issue! 👍

@erdlet erdlet closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants