Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Platform requirements for spec providing standalone TCKs #762

Closed
scottmarlow opened this issue Oct 19, 2021 · 4 comments
Closed
Labels
10.0 Issues related to the Jakarta EE 10 Platform TCK release

Comments

@scottmarlow
Copy link
Contributor

See jakartaee/jsonp-api#297 discussion about possible ways to validate Platform requirements for JSONP.

@scottmarlow scottmarlow added the 10.0 Issues related to the Jakarta EE 10 Platform TCK release label Oct 19, 2021
@scottmarlow scottmarlow added this to Unassigned in Platform TCK 10 via automation Oct 19, 2021
@scottmarlow scottmarlow changed the title Validate Platform requiremsnts for JSONP Validate Platform requirements for JSONP Oct 19, 2021
@lukasj
Copy link
Contributor

lukasj commented Oct 20, 2021

this can be generalized to Validate Platform requirements for spec providing standalone TCKs to cover ie JSONB or JAXRS as well

@scottmarlow scottmarlow changed the title Validate Platform requirements for JSONP Validate Platform requirements for spec providing standalone TCKs Oct 20, 2021
@scottmarlow
Copy link
Contributor Author

scottmarlow commented Oct 20, 2021

@m0mus
Copy link
Contributor

m0mus commented Oct 21, 2021

Here is my understanding about how it should work.

Standalone TCK tests

  • Each specification should contain standalone TCK tests in a separate repository or in API repository. Standalone tests are testing an implantation in Java SE container.
  • It doesn't matter what technologies are used to write TCK tests. Important that TCK tests are released as a Maven artifact and can be run as part of an implementation project testing.
  • In order to test an implementation for compliance, the implementation must pass all standalone TCK tests.

Jakarta Platform TCK tests

  • A spec can define some additional requirements when it's used as part of Jakarta platform. In this case Jakarta Platform should contain TCK tests for this functionality. It should not include all standalone spec TCK tests. It's a separate set of tests and can be relatively small.
  • It doesn't matter what technology Jakarta Platform is using for TCK tests. It's up to the platform or Jakarta TCK project to decide.
  • In order to test a platform implementation, the implementation must use certified implementation for each spec (see 3-rd bullet in the section above) and pass all platform TCK tests (see a bullet above).

@starksm64
Copy link
Contributor

I think this proposal is good. The details today are mixed in that ideally the current TCK level dependencies would match API dependencies. For example CDI is relatively early on the in the API dependency tree, but it has tests for all downstream containers. Ideally there would be a set of profile tests that could be integrated into the respective profile/platform TCK, but we don't have the common infrastructure to easily support this today.

Platform TCK 10 automation moved this from Unassigned to Done Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.0 Issues related to the Jakarta EE 10 Platform TCK release
Projects
Development

No branches or pull requests

4 participants