Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tck-challege] Jakarta EE Core TCK's cdi-lite-tck-suite.xml out of sync with CDI's tck-tests.xml #763

Closed
jamezp opened this issue Oct 12, 2023 · 1 comment
Labels
challenge TCK challenge

Comments

@jamezp
Copy link

jamezp commented Oct 12, 2023

Challenged tests
There are 3 CDI tests that should be excluded from the Jakarta EE Core TCK's CDI Lite TCK that are not:

  • org.jboss.cdi.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest
  • org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContextTest
  • org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest

TCK Version
Jakarta EE Core TCK 10, specifically the CDI TCK 4.0

Description
The cdi-lite-tck-suite.xml is out of sync with CDI's tck-tests.xml. These tests should be excluded in the cdi-lite-tck-suite.xml:

<!-- https://github.com/jakartaee/cdi-tck/issues/453 -->
<class name="org.jboss.cdi.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest">
    <methods>
        <exclude name="testCreateReturnsSameBeanPushed"/>
    </methods>
</class>
<class name="org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContextTest">
    <methods>
        <exclude name="testDestroyForSameCreationalContextOnly"/>
    </methods>
</class>

<!-- https://github.com/jakartaee/cdi-tck/issues/485 -->
<class name="org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest">
    <methods>
        <exclude name=".*"/>
    </methods>
</class>

The latter (org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest) causes issues with the TCK passing on Java 21.

I'm not exactly certain on the rules here, but can we exclude the tests via a build configuration? In other words, could a container update its maven-surefire-plugin to explicitly exclude the tests or must the exclusions come from the downloaded TCK itself?

Additional context
The CDI TCK Challenge issues:

@jamezp
Copy link
Author

jamezp commented Oct 13, 2023

Closing this as it should have been filed on the platform-tck project. See jakartaee/platform-tck#1196.

@jamezp jamezp closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

1 participant