Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCK Challenge] dispatchAfterCommitTest4 #489

Closed
mnriem opened this issue Dec 4, 2022 · 4 comments
Closed

[TCK Challenge] dispatchAfterCommitTest4 #489

mnriem opened this issue Dec 4, 2022 · 4 comments
Labels
accepted TCK challenge accepted challenge TCK challenge

Comments

@mnriem
Copy link

mnriem commented Dec 4, 2022

The com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest4 fails,
because it is using ServletContext.getContext(path) and in Piranha it returns null (which is allowed) and thus the test fails.

See https://github.com/jakartaee/platform-tck/blob/b23c9554913750a532fd60596b09254a8c7340a0/src/com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/DispatchTestServlet.java#L1079 
for the offending line.
@markt-asf markt-asf added Action:Accepted The Issue has been triaged and accepted for further work/analysis challenge TCK challenge accepted TCK challenge accepted and removed Action:Accepted The Issue has been triaged and accepted for further work/analysis labels Dec 6, 2022
@mnriem
Copy link
Author

mnriem commented Feb 19, 2023

@markt-asf What is the status of this issue?

@markt-asf
Copy link
Contributor

The test can be excluded for now and we'll fix it for 6.1.

@mnriem mnriem mentioned this issue Mar 6, 2023
Closed
@mnriem mnriem mentioned this issue Apr 16, 2023
Closed
@olamy
Copy link
Contributor

olamy commented Nov 1, 2023

see #553

@mnriem
Copy link
Author

mnriem commented Dec 28, 2023

@olamy @markt-asf Can I close this one out now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted TCK challenge accepted challenge TCK challenge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olamy @markt-asf @mnriem