Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NSTool reports wrong or unknown NCA Type #95

Closed
jakcron opened this issue Feb 12, 2023 · 5 comments
Closed

[BUG] NSTool reports wrong or unknown NCA Type #95

jakcron opened this issue Feb 12, 2023 · 5 comments

Comments

@jakcron
Copy link
Owner

jakcron commented Feb 12, 2023

About

When reading NCA files, with the exception of "Program" titles, Content Type under [NCA Header] is formatted incorrectly.

Example

This was taken from the *.cnmt.nca from Just Dance 2022 [0100EA6014BB8000][v0].nsp

[NCA Header]
  Format Type:     NCA3
  Dist. Type:      Download
  Content Type:    unk_0x01
  Key Generation:  11
  Sig. Generation: 0
  Kaek Index:      Application (0)
  Size:            0xe00
  ProgID:          0x0100ea6014bb8000
  Content Index:   0
  SdkAddon Ver.:   12.0.0 (v201326592)
@jakcron
Copy link
Owner Author

jakcron commented Feb 12, 2023

This appears to be an issue with the enum definition in nca.h

	enum ContentType : byte_t
	{
		ContentType_Program = 0,
		ContentType_Meta = 2, // <- should be 1
		ContentType_Control = 3, // <- should be 2
		ContentType_Manual = 4, // <- should be 3
		ContentType_Data = 5, // <- should be 4
		ContentType_PublicData = 6 // <- should be 5
	};

@jakcron
Copy link
Owner Author

jakcron commented Feb 12, 2023

Looks like that regression was introduced in this commit: jakcron/libpietendo@7dae44a

@jakcron
Copy link
Owner Author

jakcron commented Feb 12, 2023

This was fixed in libpietendo. Should be able to make a fix soon.

@Yoti
Copy link

Yoti commented Dec 29, 2023

Should be able to make a fix soon.

Any plans for a new release?

@jakcron
Copy link
Owner Author

jakcron commented Dec 31, 2023

This issue has been fixed in NSTool 1.8.0

@jakcron jakcron closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants